-
Notifications
You must be signed in to change notification settings - Fork 479
feat(npm): add backend to fetch data from private registries #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(npm): add backend to fetch data from private registries #1812
Conversation
|
Thanks for the contribution! |
Changed Packages
|
f383a9b to
272b83e
Compare
7d08a0d to
414cc3b
Compare
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
efde1e6 to
18089d0
Compare
da752d3 to
855fd41
Compare
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
855fd41 to
840b902
Compare
|
@karthikjeeyar @awanlin I finally got the backend plugin into a state where I'm mostly happy. And kind of feedback is very welcome. :) |
0b5b598 to
fee0db6
Compare
…is loaded from GitLab Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
fee0db6 to
fe1d448
Compare
awanlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @christoph-jerolimov, as mentioned previously let's try out the pattern you've got for the README files and see how it works once published to NPM.
Going to approve but leave the merging to you. 👍
|
@awanlin it didn't worked. 😞 https://github.com/backstage/community-plugins/actions/runs/12773015777/job/35604234982 Sorry that I didn't tried yarn pack... I will take care of that later with a follow-up PR. |
|
No worries, I think it was good that we gave this a try and now we know it won't work. 👍 |
Hey, I just made a Pull Request!
isNpmPackageThe included backstage app contains catalog examples for npmjs and GitHub. Also if the GitHub example is public, it requires an authtoken and an
app-config.local.yamllike this:Catalog entities can reference this registries with a new annotation:
The GitHub example looks then like this:
http://localhost:3000/catalog/default/component/github-packages-examples
The local backstage incl. a catalog entity for the tech docs:
http://localhost:3000/docs/default/component/backstage-plugin-npm
✔️ Checklist
Signed-off-byline in the message. (more info)