confluence-collator: make parallelismLimit optional #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
Changed Packages
|
|
@fjudith tagging you manually on this, I think we have an issue with CODEOWNERS on this repo (already reported to maintainers). |
fjudith
approved these changes
Nov 8, 2024
|
Thank you @mtlewis , this makes sense to make this parameter optional |
vinzscam
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Since this field already has a default value in code (cf. read, usage), it seems reasonable to mark it as optional in the schema. This allows people to skip setting it, and rely on the default value, which is already included in the field description.
✔️ Checklist
Signed-off-byline in the message. (more info)