-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes copilot backend plugin name to make backend installation work #1846
Conversation
Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
Changed Packages
|
Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changeset. Lgtm!
@@ -15,10 +15,15 @@ To configure the plugin using the new backend system: | |||
|
|||
const backend = createBackend(); | |||
|
|||
backend.add(import('@backstage-community/plugin-copilot')); | |||
backend.add(import('@backstage-community/plugin-copilot-backend')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are here we could make it a diff :D
import { createBackend } from '@backstage/backend-defaults';
const backend = createBackend();
+ backend.add(import('@backstage-community/plugin-copilot-backend'));
backend.start();
|
||
backend.start(); | ||
``` | ||
2. Add the package as a dependency in the backend workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be Step 1
so that it is consistent with the "Old system" instructions?
The wording could also be made consistent i.e.
"Add the @backstage-community/plugin-copilot-backend
package to your backend:"
|
||
```sh | ||
yarn --cwd packages/backend add @backstage-community/plugin-copilot-backend | ||
``` | ||
|
||
### Old System | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the "old system" instructions also be updated to reference @backstage-community/plugin-copilot-backend
?
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-by
line in the message. (more info)