Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes copilot backend plugin name to make backend installation work #1846

Closed
wants to merge 6 commits into from

Conversation

hubwoop
Copy link

@hubwoop hubwoop commented Nov 6, 2024

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
@hubwoop hubwoop requested a review from a team as a code owner November 6, 2024 10:01
@hubwoop hubwoop requested a review from vinzscam November 6, 2024 10:01
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 6, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-copilot-backend workspaces/copilot/plugins/copilot-backend patch v0.1.5

Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
Signed-off-by: Jonas Mai <hubwoop@users.noreply.github.com>
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changeset. Lgtm!

@@ -15,10 +15,15 @@ To configure the plugin using the new backend system:

const backend = createBackend();

backend.add(import('@backstage-community/plugin-copilot'));
backend.add(import('@backstage-community/plugin-copilot-backend'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are here we could make it a diff :D

  import { createBackend } from '@backstage/backend-defaults';

  const backend = createBackend();

+ backend.add(import('@backstage-community/plugin-copilot-backend'));

  backend.start();


backend.start();
```
2. Add the package as a dependency in the backend workspace

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be Step 1 so that it is consistent with the "Old system" instructions?

The wording could also be made consistent i.e.

"Add the @backstage-community/plugin-copilot-backend package to your backend:"


```sh
yarn --cwd packages/backend add @backstage-community/plugin-copilot-backend
```

### Old System

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the "old system" instructions also be updated to reference @backstage-community/plugin-copilot-backend?

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Nov 25, 2024
@github-actions github-actions bot closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants