fix(azure-devops): corrected api report #1871
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
|
Hi @christoph-jerolimov, good catch and thanks for the PR. Please do not merge this, I specific reasons for doing this migration and would like to handle it on my own to fully understand what went wrong and make sure that's included in my documentation. When I'm ready I'll follow up. |
There was a problem hiding this comment.
OK, figured this out, got surprised initially as I thought this was a MUI v5 migration issue but this is in the API Reports. The issue comes from two places - partly myself for not rebasing the branch once #1803 was merge and partly due to this bug.
Can we update the PR title to this:
Azure DevOps - Corrected API Report
And then in the description put a note like this:
Updated the API Report as it was missed in #1805 due to not being rebased after #1803 was merged which fixed an issue caused by backstage/backstage#27551
Also, totally fine with not having a changeset, that makes sense to me 👍
christoph-jerolimov
changed the title
|
Rebased and updated the commit message, PR title and first PR comment |
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
fix-azure-devops-release
branch
from
b45732e to
76686fb
Compare
christoph-jerolimov
changed the title
This reverts commit 1fbf57e.
This reverts commit 1fbf57e. Signed-off-by: Andre Wanlin <awanlin@spotify.com>
* Revert "Azure DevOps - Migrated to MUI v5 (#1805)" This reverts commit c5283ca. Signed-off-by: Andre Wanlin <awanlin@spotify.com> * Revert "fix(azure-devops): corrected api report (#1871)" This reverts commit 1fbf57e. Signed-off-by: Andre Wanlin <awanlin@spotify.com> * Added changeset Signed-off-by: Andre Wanlin <awanlin@spotify.com> --------- Signed-off-by: Andre Wanlin <awanlin@spotify.com>
* Revert "Azure DevOps - Migrated to MUI v5 (backstage#1805)" This reverts commit c5283ca. Signed-off-by: Andre Wanlin <awanlin@spotify.com> * Revert "fix(azure-devops): corrected api report (backstage#1871)" This reverts commit 1fbf57e. Signed-off-by: Andre Wanlin <awanlin@spotify.com> * Added changeset Signed-off-by: Andre Wanlin <awanlin@spotify.com> --------- Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Hey, I just made a Pull Request!
Hey @awanlin, maybe you have doing something similar in the same moment... Just wanted help.
Updated the API Report as it was missed in #1805 due to not being rebased after #1803 was merged which fixed an issue caused by backstage/backstage#27551
It doesn't include a changeset because its included in yours and the release PR will be stuck until this gets in.
Hope that helps.
✔️ Checklist
Signed-off-byline in the message. (more info)