-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(acr): fix dev page and update rhdh theme (dev dependency) #1875
chore(acr): fix dev page and update rhdh theme (dev dependency) #1875
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
@invincibleJai @debsmita1 @divyanshiGupta, can one of you test and lgtm this small change? |
lgtm Thank you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
37497de
to
ed5402e
Compare
Thanks @christoph-jerolimov , verified the changes Before: After: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Hey, I just made a Pull Request!
app-config.yaml
(added one from a new backstage app)I don't added a changeset because it doesn't update the plugin itself.
To test the dev page:
Without the
app-config.yaml
it was broken.With the
app-config.yaml
, but without the Page, Header and TabbedLayout it looked like this:Finally, with this change, it looks now like this:
✔️ Checklist
Signed-off-by
line in the message. (more info)