Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(acr): fix dev page and update rhdh theme (dev dependency) #1875

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Nov 6, 2024

Hey, I just made a Pull Request!

  1. Fix the dev page in general by adding the missing app-config.yaml (added one from a new backstage app)
  2. Changed the dev page to contain also a page header and tabbar, so that it looks like an entity details page
  3. Updated the rhdh-theme dev dependency (which is also just used in that dev page)

I don't added a changeset because it doesn't update the plugin itself.

To test the dev page:

cd workspace/acr
yarn install
cd plugins/acr
yarn start

Without the app-config.yaml it was broken.

With the app-config.yaml, but without the Page, Header and TabbedLayout it looked like this:

Screenshot From 2024-11-06 19-36-45

Finally, with this change, it looks now like this:

Screenshot From 2024-11-06 19-33-49

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-acr

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-acr workspaces/acr/plugins/acr none v1.8.5

@christoph-jerolimov
Copy link
Member Author

@invincibleJai @debsmita1 @divyanshiGupta, can one of you test and lgtm this small change?

@ciiay
Copy link
Contributor

ciiay commented Nov 7, 2024

lgtm

Thank you 👍

Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christoph-jerolimov christoph-jerolimov enabled auto-merge (squash) November 8, 2024 21:19
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@invincibleJai
Copy link

Thanks @christoph-jerolimov , verified the changes

Before:

image

After:

image

Copy link

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nickboldt nickboldt merged commit 6f847c7 into backstage:main Nov 12, 2024
12 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-acr-dev-page branch November 13, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants