Skip to content

BlackDuck Scaffolder - Project creation action #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 23, 2025
Merged

BlackDuck Scaffolder - Project creation action #1885

merged 16 commits into from
Feb 23, 2025

Conversation

deepan10
Copy link
Member

@deepan10 deepan10 commented Nov 7, 2024

Hey, I just made a Pull Request!

Implemented BlackDuck scaffolder for project creation action blackduck:create:project

Previous PR #1235 that was closed due to inactivity.
@04kash & @vinzscam All the review comments were fixed.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@deepan10 deepan10 requested a review from a team as a code owner November 7, 2024 08:33
@deepan10 deepan10 requested a review from vinzscam November 7, 2024 08:33
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 7, 2024 •
edited
Loading

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-blackduck

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/blackduck/packages/backend none v0.0.7
@backstage-community/plugin-blackduck-backend workspaces/blackduck/plugins/blackduck-backend patch v0.3.0
@backstage-community/plugin-blackduck-common workspaces/blackduck/plugins/blackduck-common patch v0.2.0
@backstage-community/plugin-blackduck-node workspaces/blackduck/plugins/blackduck-node patch v0.0.0
@backstage-community/plugin-blackduck workspaces/blackduck/plugins/blackduck none v0.3.0
@backstage-community/plugin-scaffolder-backend-module-blackduck workspaces/blackduck/plugins/scaffolder-backend-module-blackduck patch v0.0.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 1d73f5c to aa841dc Compare November 7, 2024 08:35
@04kash
Copy link
Member

04kash commented Nov 7, 2024

Seems like CI is failing at the check api reports step. Can you try running yarn build:api-reports ?

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 5bdd4b7 to 50189d2 Compare November 10, 2024 08:48
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from b2b434d to 42b110b Compare November 17, 2024 12:17
04kash
04kash approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all review comments were addressed

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 42b110b to b93b30f Compare November 30, 2024 06:43
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from b93b30f to f37943d Compare December 7, 2024 19:07
@deepan10
Copy link
Member Author

deepan10 commented Dec 7, 2024

Hello @vinzscam
All the comments were addressed, want to check if anything is pending from my end.

vinzscam
vinzscam reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, let's fix the changeset and then we can :shipit:

workspaces/blackduck/.changeset/lazy-days-kick.md Outdated
'@backstage-community/plugin-blackduck-backend': patch
---

Implemented blackduck scaffolder - project creation action
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move out the changeset for the backend saying "Added @backstage-community/plugin-blackduck-node as dependency".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it has to go on a separate file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vinzscam

Sorry I couldn't get it. Do you mean another changeset?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should go on a separate file containing only '@backstage-community/plugin-blackduck-backend': patch and the description above

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from d720fdf to e306caf Compare December 15, 2024 11:27
@deepan10 deepan10 requested a review from vinzscam December 15, 2024 11:35
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 6 times, most recently from 219ae70 to 2dc9371 Compare December 25, 2024 08:42
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 3 times, most recently from 1f85618 to 3cf5cd4 Compare January 7, 2025 11:46
vinzscam
vinzscam requested changes Jan 14, 2025
View reviewed changes
workspaces/blackduck/.changeset/lazy-days-kick.md Outdated
'@backstage-community/plugin-blackduck-backend': patch
---

Implemented blackduck scaffolder - project creation action
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should go on a separate file containing only '@backstage-community/plugin-blackduck-backend': patch and the description above

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 2 times, most recently from 63c26e6 to 0fdafce Compare January 18, 2025 11:10
@deepan10 deepan10 requested a review from vinzscam January 18, 2025 11:46
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 0fdafce to 5f1bf06 Compare January 18, 2025 12:54
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 5f1bf06 to 10fafae Compare January 26, 2025 20:39
vinzscam
vinzscam reviewed Jan 28, 2025
View reviewed changes
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 2 times, most recently from 3123d66 to c2e5360 Compare January 30, 2025 15:09
@deepan10 deepan10 requested a review from vinzscam January 30, 2025 15:42
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 2 times, most recently from ed39820 to 4556ed8 Compare February 1, 2025 08:03
vinzscam
vinzscam approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 2 times, most recently from 20fea91 to 073d953 Compare February 18, 2025 07:48
@deepan10
blackduck scaffolder - project creation action
cc2e5ec 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
fixed scaffolder module package.json
b66e8f2 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
Review comments fixed
b4b073c 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
package & template fixed
75e389e 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
API Report fixed
96a492a 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
added blackduck-node library
30fb25f 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
Updated project creation request
35b0ef6 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
API Reports fixed
c7dd41a 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
dependencies fixed
d5cf5e5 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
changeset updated
fb117c6 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
yarn packages & api reports fixed
91586e3 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
fixed yarn.lock
38a98ae 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
yarn package & review comments are fixed
770fa78 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10
changeset updated
c0e6b67 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 073d953 to 95e04d5 Compare February 22, 2025 06:37
@deepan10
changeset updated and review comments fixed
a2ff5f6 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 95e04d5 to a2ff5f6 Compare February 22, 2025 07:15
@deepan10
fixed package & dependencies issues
26cbd84 
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from bfdd882 to 26cbd84 Compare February 23, 2025 09:40
@deepan10 deepan10 merged commit 638b35b into backstage:main Feb 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzscam vinzscam vinzscam approved these changes

@04kash 04kash 04kash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepan10 @04kash @vinzscam