Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlackDuck Scaffolder - Project creation action #1885

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

deepan10
Copy link
Member

@deepan10 deepan10 commented Nov 7, 2024

Hey, I just made a Pull Request!

Implemented BlackDuck scaffolder for project creation action blackduck:create:project

Previous PR #1235 that was closed due to inactivity.
@04kash & @vinzscam All the review comments were fixed.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@deepan10 deepan10 requested a review from a team as a code owner November 7, 2024 08:33
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 7, 2024

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-blackduck-common
  • @backstage-community/plugin-blackduck-node
  • @backstage-community/plugin-blackduck

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/blackduck/packages/backend none v0.0.7
@backstage-community/plugin-blackduck-backend workspaces/blackduck/plugins/blackduck-backend patch v0.0.7
@backstage-community/plugin-blackduck-common workspaces/blackduck/plugins/blackduck-common none v0.0.4
@backstage-community/plugin-blackduck-node workspaces/blackduck/plugins/blackduck-node none v0.1.0
@backstage-community/plugin-blackduck workspaces/blackduck/plugins/blackduck none v0.0.6
@backstage-community/plugin-scaffolder-backend-module-blackduck workspaces/blackduck/plugins/scaffolder-backend-module-blackduck patch v0.1.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@04kash
Copy link
Contributor

04kash commented Nov 7, 2024

Seems like CI is failing at the check api reports step. Can you try running yarn build:api-reports ?

Copy link
Contributor

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all review comments were addressed

Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants