-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlackDuck Scaffolder - Project creation action #1885
base: main
Are you sure you want to change the base?
Conversation
Changed Packages
|
Thanks for the contribution! |
1d73f5c
to
aa841dc
Compare
Seems like CI is failing at the check api reports step. Can you try running |
5bdd4b7
to
50189d2
Compare
b2b434d
to
42b110b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, all review comments were addressed
42b110b
to
b93b30f
Compare
b93b30f
to
f37943d
Compare
Hello @vinzscam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, let's fix the changeset and then we can
'@backstage-community/plugin-blackduck-backend': patch | ||
--- | ||
|
||
Implemented blackduck scaffolder - project creation action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps move out the changeset for the backend saying "Added @backstage-community/plugin-blackduck-node
as dependency".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, it has to go on a separate file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vinzscam
Sorry I couldn't get it. Do you mean another changeset?
d720fdf
to
e306caf
Compare
e5be49e
to
8069c88
Compare
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
b8e7f0d
to
219ae70
Compare
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
219ae70
to
2dc9371
Compare
Hey, I just made a Pull Request!
Implemented
BlackDuck
scaffolder for project creation actionblackduck:create:project
Previous PR #1235 that was closed due to inactivity.
@04kash & @vinzscam All the review comments were fixed.
✔️ Checklist
Signed-off-by
line in the message. (more info)