Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlackDuck Scaffolder - Project creation action #1885

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

deepan10
Copy link
Member

@deepan10 deepan10 commented Nov 7, 2024

Hey, I just made a Pull Request!

Implemented BlackDuck scaffolder for project creation action blackduck:create:project

Previous PR #1235 that was closed due to inactivity.
@04kash & @vinzscam All the review comments were fixed.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@deepan10 deepan10 requested a review from a team as a code owner November 7, 2024 08:33
@deepan10 deepan10 requested a review from vinzscam November 7, 2024 08:33
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 7, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/blackduck/packages/backend none v0.0.7
@backstage-community/plugin-blackduck-backend workspaces/blackduck/plugins/blackduck-backend patch v0.1.0
@backstage-community/plugin-blackduck-common workspaces/blackduck/plugins/blackduck-common patch v0.1.0
@backstage-community/plugin-blackduck-node workspaces/blackduck/plugins/blackduck-node patch v0.1.0
@backstage-community/plugin-blackduck workspaces/blackduck/plugins/blackduck patch v0.1.0
@backstage-community/plugin-scaffolder-backend-module-blackduck workspaces/blackduck/plugins/scaffolder-backend-module-blackduck patch v0.1.0

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 1d73f5c to aa841dc Compare November 7, 2024 08:35
@04kash
Copy link
Contributor

04kash commented Nov 7, 2024

Seems like CI is failing at the check api reports step. Can you try running yarn build:api-reports ?

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 5bdd4b7 to 50189d2 Compare November 10, 2024 08:48
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from b2b434d to 42b110b Compare November 17, 2024 12:17
Copy link
Contributor

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all review comments were addressed

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 42b110b to b93b30f Compare November 30, 2024 06:43
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from b93b30f to f37943d Compare December 7, 2024 19:07
@deepan10
Copy link
Member Author

deepan10 commented Dec 7, 2024

Hello @vinzscam
All the comments were addressed, want to check if anything is pending from my end.

Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, let's fix the changeset and then we can :shipit:

'@backstage-community/plugin-blackduck-backend': patch
---

Implemented blackduck scaffolder - project creation action
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move out the changeset for the backend saying "Added @backstage-community/plugin-blackduck-node as dependency".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it has to go on a separate file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vinzscam

Sorry I couldn't get it. Do you mean another changeset?

@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from d720fdf to e306caf Compare December 15, 2024 11:27
@deepan10 deepan10 requested a review from vinzscam December 15, 2024 11:35
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 3 times, most recently from e5be49e to 8069c88 Compare December 24, 2024 22:53
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch 2 times, most recently from b8e7f0d to 219ae70 Compare December 24, 2024 23:13
Signed-off-by: Deepankumar Loganathan <deepan0433@gmail.com>
@deepan10 deepan10 force-pushed the blackduck-scaffolder branch from 219ae70 to 2dc9371 Compare December 25, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants