Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matomo): migrate matomo frontend and backend plugins #1906

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

yashoswalyo
Copy link
Member

Hey, I just made a Pull Request!

The matomo and matomo-backend plugins from janus-idp/backstage-plugins are migrated to community-plugins. The migrations is performed using manual steps.

Screenshots

image

image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 11, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-matomo-backend workspaces/matomo/plugins/matomo-backend minor v1.11.1
@backstage-community/plugin-matomo workspaces/matomo/plugins/matomo minor v1.10.1

@yashoswalyo yashoswalyo self-assigned this Nov 11, 2024
@yashoswalyo yashoswalyo force-pushed the RHIDP-3737 branch 2 times, most recently from 2a357ea to 041539b Compare November 12, 2024 04:26
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @yashoswalyo, just have one comment I'd like your confirmation on. 👍

@@ -0,0 +1,6 @@
---
'@backstage-community/plugin-matomo-backend': major
'@backstage-community/plugin-matomo': major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want this to be major? These will end end up being 1.1.0. Your call, just want to be sure that's what you want before I approve and merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure you can go ahead

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yashoswalyo, with other plugins that we migrated from our plugin repo, we set the version in package.json to the same version as we had before.

1.8.1 for analytics-module-matomo. And then we should go with a minor or patch change here to release 1.8.2 or 1.9.0.

Can you apply these two changes to be aligned with all other migrations we're doing?

Thanks a lot :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to hold off to give you a chance to reply to the above @yashoswalyo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @christoph-jerolimov I'll update the MR

@yashoswalyo yashoswalyo force-pushed the RHIDP-3737 branch 2 times, most recently from e281339 to 53064ec Compare November 14, 2024 16:49
Signed-off-by: Yash Oswal <yoswal@redhat.com>
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @yashoswalyo 👍

@yashoswalyo yashoswalyo merged commit a522528 into backstage:main Nov 14, 2024
12 checks passed
@yashoswalyo yashoswalyo deleted the RHIDP-3737 branch November 14, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants