-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(matomo): migrate matomo frontend and backend plugins #1906
Conversation
Changed Packages
|
2a357ea
to
041539b
Compare
3189d3e
to
fa96259
Compare
32d21f2
to
511dba6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @yashoswalyo, just have one comment I'd like your confirmation on. 👍
@@ -0,0 +1,6 @@ | |||
--- | |||
'@backstage-community/plugin-matomo-backend': major | |||
'@backstage-community/plugin-matomo': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really want this to be major? These will end end up being 1.1.0
. Your call, just want to be sure that's what you want before I approve and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure you can go ahead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yashoswalyo, with other plugins that we migrated from our plugin repo, we set the version in package.json to the same version as we had before.
1.8.1 for analytics-module-matomo. And then we should go with a minor or patch change here to release 1.8.2 or 1.9.0.
Can you apply these two changes to be aligned with all other migrations we're doing?
Thanks a lot :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to hold off to give you a chance to reply to the above @yashoswalyo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @christoph-jerolimov I'll update the MR
e281339
to
53064ec
Compare
Signed-off-by: Yash Oswal <yoswal@redhat.com>
53064ec
to
4d9def6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @yashoswalyo 👍
Hey, I just made a Pull Request!
The matomo and matomo-backend plugins from janus-idp/backstage-plugins are migrated to community-plugins. The migrations is performed using manual steps.
Screenshots
✔️ Checklist
Signed-off-by
line in the message. (more info)