Fix broken docker hub url #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arshad Kazmi <arshadkazmi42@gmail.com>
Changed Packages
|
christoph-jerolimov
approved these changes
Nov 16, 2024
04kash
approved these changes
Nov 29, 2024
awanlin
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Thanks for the correction @arshadkazmi42, as this README gets published to NPM we do need a changeset for this. Details on how to do that are here: https://github.com/backstage/community-plugins/blob/main/CONTRIBUTING.md#creating-changesets
auto-merge was automatically disabled
November 29, 2024 19:40
Head branch was pushed to by a user without write access
|
Thanks for the contribution! |
Signed-off-by: Arshad Kazmi <arshadkazmi42@gmail.com>
arshadkazmi42
force-pushed
the
patch-1
branch
from
1edaa0c to
75b1631
Compare
|
@awanlin I added the changset file |
awanlin
approved these changes
Nov 29, 2024
|
Thanks @arshadkazmi42, I've approved and once the build passes this will get merged in 🚀 |
CryptoRodeo
pushed a commit
to CryptoRodeo/community-plugins
that referenced
this pull request
Dec 10, 2024
* Fix broken docker hub url Signed-off-by: Arshad Kazmi <arshadkazmi42@gmail.com> * Added changeset Signed-off-by: Arshad Kazmi <arshadkazmi42@gmail.com> --------- Signed-off-by: Arshad Kazmi <arshadkazmi42@gmail.com> Co-authored-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
There was a docker hub url mentioned in the README file. The docker hub url format was wrong and was redirecting to a 404 page.
This PR, fixes the URL
✔️ Checklist
Signed-off-byline in the message. (more info)