Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback - Removed usages and references of @backstage/backend-common #1970

Closed

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Nov 17, 2024

Hey, I just made a Pull Request!

Removed usages and references of @backstage/backend-common

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin requested review from riginoommen, yashoswalyo and a team as code owners November 17, 2024 18:41
@awanlin awanlin requested a review from vinzscam November 17, 2024 18:41
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-feedback-backend workspaces/feedback/plugins/feedback-backend patch v1.7.7

@awanlin
Copy link
Contributor Author

awanlin commented Nov 17, 2024

Hi @yashoswalyo and @riginoommen, more than happy to make changes to this based on your feedback. As @backstage/backend-common has been deprecated and I believe now has an active CVE I'm trying to remove it from all the plugins.

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin
Copy link
Contributor Author

awanlin commented Nov 17, 2024

I've made some corrections but I'll need your feedback as to how best to resolve the API Report errors in the CI. It want me to export the RouterOptions but ideally we should be removing that and the export of createRouter and pushing Adopters to using the New Backend System.

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin closed this Nov 20, 2024
@awanlin
Copy link
Contributor Author

awanlin commented Nov 20, 2024

Reason for closing outlined here: #1176 (comment)

@awanlin awanlin deleted the feedback/remove-backend-common branch November 20, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant