Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

badges - Removed usages and references of @backstage/backend-common #1976

Closed
wants to merge 3 commits into from
Closed

badges - Removed usages and references of @backstage/backend-common #1976

wants to merge 3 commits into from

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Nov 17, 2024

Hey, I just made a Pull Request!

Removed usages and references of @backstage/backend-common

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin
badges - Removed usages and references of @backstage/backend-common
636a8b5 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin requested review from backstage-service and a team as code owners November 17, 2024 19:58
@awanlin awanlin requested a review from vinzscam November 17, 2024 19:58
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 17, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-badges-backend workspaces/badges/plugins/badges-backend minor v0.5.3

@awanlin
Fixed tests
37248fe 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin
Various corrections
6dc2a1f 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin closed this Nov 20, 2024
@awanlin
Copy link
Contributor Author

awanlin commented Nov 20, 2024

Reason for closing outlined here: #1176 (comment)

@awanlin awanlin deleted the badges/remove-backend-common branch November 20, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/community-plugins-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@awanlin