Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-sites - Removed usages and references of @backstage/backend-common #1978

Closed

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Nov 17, 2024

Hey, I just made a Pull Request!

Removed usages and references of @backstage/backend-common

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

…mmon`

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@awanlin awanlin requested review from backstage-service and a team as code owners November 17, 2024 20:10
@awanlin awanlin requested a review from vinzscam November 17, 2024 20:10
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-azure-sites-backend workspaces/azure-sites/plugins/azure-sites-backend patch v0.3.10

@@ -47,16 +43,16 @@ export interface RouterOptions {
catalogApi: CatalogApi;
permissions: PermissionsService;
discovery: DiscoveryService;
auth?: AuthService;
httpAuth?: HttpAuthService;
auth: AuthService;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm how could adopter instantiate this plugin using the legacy backend system? 🤔

@awanlin awanlin closed this Nov 20, 2024
@awanlin
Copy link
Contributor Author

awanlin commented Nov 20, 2024

Reason for closing outlined here: #1176 (comment)

@awanlin awanlin deleted the azure-sites/remove-backend-common branch November 20, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants