-
Notifications
You must be signed in to change notification settings - Fork 383
Linguist api docs #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linguist api docs #2062
Conversation
Changed Packages
|
Hi @bforbis, I've been pretty busy as of late but wanted to share that I have seen this. I'm currently a bit torn on this one as I often point to this plugin as a good example of patterns. I like that it's very close to the default plugin structure. I also personally take a code first approach to development and this would be a change for me. I'll keep thinking on this though, I'm not totally on the side of saying no, again just didn't want to keep you in the dark on my thinking. |
@awanlin, thanks and no problem on being busy! I am just copying the patterns that exist for The API for linguist is simple enough that switching between either approach won't be too much effort. I think openapi tooling for backstage will continue to evolve, so if some better code-genarated API spec tooling is available in the future this could be ported to it. |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hoping to review this today or tomorrow 👍 But there are conflicts @bforbis, can you take a look at those, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff! 😁
06c0631
to
94250f9
Compare
Dropped the |
94250f9
to
97fb925
Compare
One more fix for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's move this forward @bforbis, left one small comment and would also like confirmation on once comment you posted.
@bforbis, if you can fix the conflicts that crept in I'll follow up with approval and merging 👍 |
Signed-off-by: Brian Forbis <bforbis@athenahealth.com>
Signed-off-by: Brian Forbis <bforbis@athenahealth.com>
Co-authored-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com> Signed-off-by: bforbis <bpforbis@gmail.com>
010c9d7
to
d46fa54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move forward with this 👍
Hey, I just made a Pull Request!
I've been getting into the API docs functionality that has been added for plugin backends and would like to add API specs for the linguist backend.
✔️ Checklist
Signed-off-by
line in the message. (more info)