Skip to content

Linguist api docs #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Linguist api docs #2062

merged 4 commits into from
Jan 7, 2025

Conversation

bforbis
Copy link
Contributor

@bforbis bforbis commented Nov 22, 2024

Hey, I just made a Pull Request!

I've been getting into the API docs functionality that has been added for plugin backends and would like to add API specs for the linguist backend.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)
image

@bforbis bforbis requested review from awanlin and a team as code owners November 22, 2024 16:30
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 22, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/linguist/packages/backend none v0.0.16
@backstage-community/plugin-linguist-backend workspaces/linguist/plugins/linguist-backend minor v0.9.0

@awanlin
Copy link
Contributor

awanlin commented Nov 26, 2024

Hi @bforbis, I've been pretty busy as of late but wanted to share that I have seen this.

I'm currently a bit torn on this one as I often point to this plugin as a good example of patterns. I like that it's very close to the default plugin structure. I also personally take a code first approach to development and this would be a change for me.

I'll keep thinking on this though, I'm not totally on the side of saying no, again just didn't want to keep you in the dark on my thinking.

@bforbis
Copy link
Contributor Author

bforbis commented Nov 27, 2024

@awanlin, thanks and no problem on being busy!

I am just copying the patterns that exist for catalog, search, and events right now. I don't have a lot of opinions on whether its spec first vs code first, just wanted the ability to see the linguist API in my stitched together backstage OpenAPI spec.

The API for linguist is simple enough that switching between either approach won't be too much effort. I think openapi tooling for backstage will continue to evolve, so if some better code-genarated API spec tooling is available in the future this could be ported to it.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Dec 11, 2024
@awanlin
Copy link
Contributor

awanlin commented Dec 13, 2024

Hoping to review this today or tomorrow 👍

But there are conflicts @bforbis, can you take a look at those, please?

@github-actions github-actions bot removed the stale label Dec 13, 2024
Copy link

@aramissennyeydd aramissennyeydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting stuff! 😁

@bforbis bforbis force-pushed the linguist-api-docs branch 2 times, most recently from 06c0631 to 94250f9 Compare December 17, 2024 20:39
@bforbis
Copy link
Contributor Author

bforbis commented Dec 17, 2024

Dropped the optic.yml file as it is not needed and additionally rebased off main to fix package / lock conflicts.

@bforbis
Copy link
Contributor Author

bforbis commented Dec 17, 2024

One more fix for yarn dedupe

Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's move this forward @bforbis, left one small comment and would also like confirmation on once comment you posted.

@awanlin
Copy link
Contributor

awanlin commented Dec 24, 2024

@bforbis, if you can fix the conflicts that crept in I'll follow up with approval and merging 👍

bforbis and others added 3 commits January 3, 2025 21:38
Signed-off-by: Brian Forbis <bforbis@athenahealth.com>
Signed-off-by: Brian Forbis <bforbis@athenahealth.com>
Co-authored-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
Signed-off-by: bforbis <bpforbis@gmail.com>
@bforbis bforbis force-pushed the linguist-api-docs branch from 010c9d7 to d46fa54 Compare January 4, 2025 02:38
@awanlin awanlin enabled auto-merge (squash) January 7, 2025 15:36
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward with this 👍

@awanlin awanlin merged commit 8585c65 into backstage:main Jan 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants