Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create announcements workspace and migrate search module #2148

Merged
merged 20 commits into from
Dec 19, 2024

Conversation

kurtaking
Copy link
Contributor

@kurtaking kurtaking commented Dec 6, 2024

Hey, I just made a Pull Request!

This PR includes the initial announcements workspace via yarn create-workspace, along with the search module from procore-oss.

The remaining plugins will be migrated in individual follow up PRs. I previously tried migrating all plugins at once which created a bloated PR.

Recap

  • create new announcements workspace
  • migrate the announcements search module
  • add myself to codeowners for the workspace

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Kurt King <kurtaking@gmail.com>
Signed-off-by: Kurt King <kurtaking@gmail.com>
@kurtaking kurtaking requested review from backstage-service and a team as code owners December 6, 2024 20:14
@kurtaking kurtaking requested a review from vinzscam December 6, 2024 20:14
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-search-backend-module-announcements workspaces/announcements/plugins/search-backend-module-announcements none v0.1.0

Signed-off-by: Kurt King <kurtaking@gmail.com>
Signed-off-by: Kurt King <kurtaking@gmail.com>
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @kurtaking 🙏
don't forget to add yourself to the CODEOWNERS

@kurtaking
Copy link
Contributor Author

thank you @kurtaking 🙏 don't forget to add yourself to the CODEOWNERS

Oooh, good catch @vinzscam - added.

@kurtaking
Copy link
Contributor Author

I've also submitted backstage/community#172.

Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @kurtaking

Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need a changeset

@kurtaking
Copy link
Contributor Author

Ah, we need a changeset

I meant to include this in the description - my intentions were to migrate all plugins and then release a changeset once we were ready to tell the community to migrate.

@awanlin awanlin merged commit 0e2ee41 into backstage:main Dec 19, 2024
12 checks passed
@kurtaking kurtaking deleted the announcements-search-module branch December 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants