-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create announcements workspace and migrate search module #2148
Create announcements workspace and migrate search module #2148
Conversation
Signed-off-by: Kurt King <kurtaking@gmail.com>
Signed-off-by: Kurt King <kurtaking@gmail.com>
Changed Packages
|
Signed-off-by: Kurt King <kurtaking@gmail.com>
Signed-off-by: Kurt King <kurtaking@gmail.com>
Signed-off-by: Kurt King <kurtaking@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @kurtaking 🙏
don't forget to add yourself to the CODEOWNERS
Signed-off-by: Kurt King <kurtaking@gmail.com>
Oooh, good catch @vinzscam - added. |
I've also submitted backstage/community#172. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @kurtaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we need a changeset
I meant to include this in the description - my intentions were to migrate all plugins and then release a changeset once we were ready to tell the community to migrate. |
Hey, I just made a Pull Request!
This PR includes the initial announcements workspace via
yarn create-workspace
, along with the search module fromprocore-oss
.The remaining plugins will be migrated in individual follow up PRs. I previously tried migrating all plugins at once which created a bloated PR.
Recap
✔️ Checklist
Signed-off-by
line in the message. (more info)