New tech insights maturity plugin based on tech-insights #2464

hballangan-mdsol · 2025-01-08T05:20:39Z

Hey, I just made a Pull Request!

Create new a Tech Insights plugin extension called Tech Insights Maturity.
This is a frontend extension of tech-insights plugin and can be used alongside vanilla tech-insights-backend plugin or any of its implementations like tech-insights-backend-module-jsonfc.

(More screenshots also attached in readme)

For more info, see README

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)
All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

backstage-goalie · 2025-01-08T05:21:08Z

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

@backstage-community/plugin-tech-insights-backend
@backstage-community/plugin-tech-insights-common
@backstage-community/plugin-tech-insights-maturity-common
@backstage-community/plugin-tech-insights-maturity
@backstage-community/plugin-tech-insights-node
@backstage-community/plugin-tech-insights

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage-community/plugin-tech-insights-backend	workspaces/tech-insights/plugins/tech-insights-backend	none	`v2.1.1`
@backstage-community/plugin-tech-insights-common	workspaces/tech-insights/plugins/tech-insights-common	none	`v0.4.0`
@backstage-community/plugin-tech-insights-maturity-common	workspaces/tech-insights/plugins/tech-insights-maturity-common	none	`v0.1.0`
@backstage-community/plugin-tech-insights-maturity	workspaces/tech-insights/plugins/tech-insights-maturity	none	`v0.1.0`
@backstage-community/plugin-tech-insights-node	workspaces/tech-insights/plugins/tech-insights-node	none	`v2.2.0`
@backstage-community/plugin-tech-insights	workspaces/tech-insights/plugins/tech-insights	none	`v0.4.0`

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

…ballangan-mdsol/community-plugins into feature/tech-insights-maturity

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

…ballangan-mdsol/community-plugins into feature/tech-insights-maturity

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

awanlin · 2025-01-10T21:05:46Z

Hi @hballangan-mdsol, would it make sense to just add this into the current tech-insights workspace instead of creating a new one considering the tight coupling?

@Xantier, what do you think?

Xantier · 2025-01-13T08:12:06Z

Thanks for the contribution, looks stellar!

Yup, probably makes sense to use the existing workspace to keep everything more easily findable

hballangan-mdsol · 2025-01-14T03:22:12Z

Hi @awanlin and @Xantier ! Thanks for checkin the PR! Makes sense to add it to tech-insights, is it okay to keep the naming for the 2 plugin folders when I move it there?

Xantier · 2025-01-14T08:44:01Z

Is it okay to keep the naming for the 2 plugin folders when I move it there?

Yup, those look good to me

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

workspaces/tech-insights/plugins/tech-insights-maturity/src/api/ScoringDataApi.ts

workspaces/tech-insights/plugins/tech-insights-maturity/src/helpers/getWarningPanel.tsx

workspaces/tech-insights/plugins/tech-insights-maturity/src/helpers/CustomWidthToolTip.tsx

workspaces/tech-insights/plugins/tech-insights-maturity/src/helpers/utils.ts

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

hballangan-mdsol · 2025-01-23T04:54:41Z

Thanks @kurtaking for checking out unused components! I've removed all components not being used here, and renamed legacy files that were refactored.

workspaces/tech-insights/plugins/tech-insights-maturity/src/api/MaturityApi.ts

kurtaking · 2025-01-23T05:50:22Z

I think someone needs to approve running CI for the PR.

@hballangan-mdsol - once that happens, I think you are going to run into some failures based on the package.json and api reports.

I opened hballangan-mdsol#1 against your fork to show you the changes that were made when running

yarn backstage-cli repo fix --publish
yarn build:api-reports

…i/MaturityApi.ts Co-authored-by: Kurt King <kurtaking@gmail.com> Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

hballangan-mdsol · 2025-01-24T04:05:20Z

I think someone needs to approve running CI for the PR.

@hballangan-mdsol - once that happens, I think you are going to run into some failures based on the package.json and api reports.

I opened hballangan-mdsol#1 against your fork to show you the changes that were made when running
yarn backstage-cli repo fix --publish
yarn build:api-reports

@kurtaking Thanks for the helpful fixes and suggestions! You've been very helpful in cleaning up this plugin. 🙏🏼

@Xantier aside from the configurable descriptions which we can update in the following version, will this this be good for merging?

Xantier · 2025-01-24T07:13:57Z

@Xantier aside from the configurable descriptions which we can update in the following version, will this this be good for merging?

I'll take a last look at this today but from a cursory overview, this seems to look ok to ship as a first release

Xantier · 2025-01-24T10:28:00Z

workspaces/tech-insights/plugins/tech-insights-maturity/src/api/ScoringDataFormatter.ts

This could be something to expose and inject to the client in the future if there are wants to modify the logic here

Xantier

Nice!

Conflicts in the PR

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

hballangan-mdsol · 2025-01-27T08:45:08Z

Nice!

Resolved the conflicts and all checks are now passing. Kindly review again 🙏🏼 @Xantier

kurtaking · 2025-01-27T20:59:23Z

Nice work @hballangan-mdsol !

hballangan-mdsol · 2025-01-28T05:07:52Z

Nice work @hballangan-mdsol !

Thanks for all the help @kurtaking and @Xantier !
Looking forward to more collaborations in developing this plugin!

) * init tech-insights-maturity Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * add eslint Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * rename plugin export naming Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * update readme Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * MaturityApiRef to extend TechInsightsApiRef Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * sanitize and refactor Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * export EntityMaturitySummaryContent Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * fix remaining issue Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * update package dependencies Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * resolve use-react tsc issue Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * run prettier Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * generate build report Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * use workspace package Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * yarn fix Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * move tech-insights-maturity to tech-insights workspace Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * refactor Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * add missing dependency Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * fix imported dependency Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * refactor getMaturityScore Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * remove custom org implementations Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * Apply suggestions from code review Co-authored-by: Kurt King <kurtaking@gmail.com> Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * refactor MaturityLink Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * remove non-common plugin dependencies in maturity-common Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * remove unused components Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * remove unused components Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * Update workspaces/tech-insights/plugins/tech-insights-maturity/src/api/MaturityApi.ts Co-authored-by: Kurt King <kurtaking@gmail.com> Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * update packages and report Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * update yarn packages Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * sync merge conflict Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * run yarn dedupe Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * generate api report md Signed-off-by: Maica Ballangan <hballangan@mdsol.com> * refactor maturityrank Signed-off-by: Maica Ballangan <hballangan@mdsol.com> --------- Signed-off-by: Maica Ballangan <hballangan@mdsol.com> Co-authored-by: Kurt King <kurtaking@gmail.com> Signed-off-by: gaelgoth <gothuey.gael@gmail.com>

hballangan-mdsol added 2 commits January 8, 2025 14:19

init tech-insights-maturity

4fecafd

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

add eslint

b7e2e42

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

hballangan-mdsol requested review from backstage-service and a team as code owners January 8, 2025 05:20

hballangan-mdsol requested a review from nickboldt January 8, 2025 05:20

Merge branch 'main' into feature/tech-insights-maturity

51f12dc

hballangan-mdsol added 15 commits January 8, 2025 19:37

rename plugin export naming

b38f33c

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

update readme

c77b522

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

Merge branch 'feature/tech-insights-maturity' of https://github.com/h…

7c06ca5

…ballangan-mdsol/community-plugins into feature/tech-insights-maturity

MaturityApiRef to extend TechInsightsApiRef

808b10e

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

sanitize and refactor

4be4f05

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

export EntityMaturitySummaryContent

d6a88c7

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

fix remaining issue

4b1be66

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

Merge branch 'main' into feature/tech-insights-maturity

8a65ddb

update package dependencies

4d118c2

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

Merge branch 'feature/tech-insights-maturity' of https://github.com/h…

a6d175e

…ballangan-mdsol/community-plugins into feature/tech-insights-maturity

resolve use-react tsc issue

af95e28

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

run prettier

f65e2f9

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

generate build report

4c047d2

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

use workspace package

b55548e

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

yarn fix

4851de9

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

awanlin requested a review from Xantier January 10, 2025 21:06

hballangan-mdsol added 3 commits January 15, 2025 23:05

move tech-insights-maturity to tech-insights workspace

83506bc

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

refactor

da85c52

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

add missing dependency

779c07e

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

kurtaking reviewed Jan 22, 2025

View reviewed changes

workspaces/tech-insights/plugins/tech-insights-maturity/src/api/ScoringDataApi.ts Outdated Show resolved Hide resolved

workspaces/tech-insights/plugins/tech-insights-maturity/src/helpers/getWarningPanel.tsx Outdated Show resolved Hide resolved

kurtaking reviewed Jan 22, 2025

View reviewed changes

workspaces/tech-insights/plugins/tech-insights-maturity/src/helpers/CustomWidthToolTip.tsx Outdated Show resolved Hide resolved

kurtaking reviewed Jan 22, 2025

View reviewed changes

workspaces/tech-insights/plugins/tech-insights-maturity/src/helpers/utils.ts Outdated Show resolved Hide resolved

hballangan-mdsol added 2 commits January 23, 2025 13:48

remove unused components

15d9ac9

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

remove unused components

ca3e683

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

kurtaking reviewed Jan 23, 2025

View reviewed changes

workspaces/tech-insights/plugins/tech-insights-maturity/src/api/MaturityApi.ts Outdated Show resolved Hide resolved

hballangan-mdsol and others added 3 commits January 23, 2025 17:22

Update workspaces/tech-insights/plugins/tech-insights-maturity/src/ap…

a609310

…i/MaturityApi.ts Co-authored-by: Kurt King <kurtaking@gmail.com> Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

update packages and report

ed2ca6d

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

update yarn packages

4042fb1

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

Xantier reviewed Jan 24, 2025

View reviewed changes

Xantier previously approved these changes Jan 24, 2025

View reviewed changes

hballangan-mdsol added 6 commits January 25, 2025 00:01

sync merge conflict

1853ac5

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

Merge branch 'main' into feature/tech-insights-maturity

789c66e

run yarn dedupe

957590a

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

generate api report md

1e4514f

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

Merge branch 'main' into feature/tech-insights-maturity

a799199

refactor maturityrank

ec0a186

Signed-off-by: Maica Ballangan <hballangan@mdsol.com>

kurtaking mentioned this pull request Jan 24, 2025

New plugin: Manage #2569

Open

5 tasks

Xantier approved these changes Jan 27, 2025

View reviewed changes

Xantier merged commit 561d661 into backstage:main Jan 27, 2025
12 checks passed

hballangan-mdsol deleted the feature/tech-insights-maturity branch January 28, 2025 04:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New tech insights maturity plugin based on tech-insights #2464

New tech insights maturity plugin based on tech-insights #2464

hballangan-mdsol commented Jan 8, 2025 •

edited

Loading

backstage-goalie bot commented Jan 8, 2025 •

edited

Loading

awanlin commented Jan 10, 2025

Xantier commented Jan 13, 2025

hballangan-mdsol commented Jan 14, 2025

Xantier commented Jan 14, 2025

hballangan-mdsol commented Jan 23, 2025

kurtaking commented Jan 23, 2025

hballangan-mdsol commented Jan 24, 2025 •

edited

Loading

Xantier commented Jan 24, 2025

Xantier Jan 24, 2025

Xantier left a comment

hballangan-mdsol commented Jan 27, 2025

kurtaking commented Jan 27, 2025

hballangan-mdsol commented Jan 28, 2025

New tech insights maturity plugin based on tech-insights #2464

New tech insights maturity plugin based on tech-insights #2464

Conversation

hballangan-mdsol commented Jan 8, 2025 • edited Loading

Hey, I just made a Pull Request!

✔️ Checklist

backstage-goalie bot commented Jan 8, 2025 • edited Loading

Missing Changesets

Changed Packages

awanlin commented Jan 10, 2025

Xantier commented Jan 13, 2025

hballangan-mdsol commented Jan 14, 2025

Xantier commented Jan 14, 2025

hballangan-mdsol commented Jan 23, 2025

kurtaking commented Jan 23, 2025

hballangan-mdsol commented Jan 24, 2025 • edited Loading

Xantier commented Jan 24, 2025

Xantier Jan 24, 2025

Choose a reason for hiding this comment

Xantier left a comment

Choose a reason for hiding this comment

hballangan-mdsol commented Jan 27, 2025

kurtaking commented Jan 27, 2025

hballangan-mdsol commented Jan 28, 2025

hballangan-mdsol commented Jan 8, 2025 •

edited

Loading

backstage-goalie bot commented Jan 8, 2025 •

edited

Loading

hballangan-mdsol commented Jan 24, 2025 •

edited

Loading