Skip to content

feat(DependencyTrack): Migrated dependency track plugin to community plugins #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 347 commits into from
Closed

feat(DependencyTrack): Migrated dependency track plugin to community plugins #2534

wants to merge 347 commits into from

Conversation

harmenbrinkmanTRIMM
Copy link

…plugins

Hey, I just made a Pull Request!

Migrated dependencytrack plugin to community plugins.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-dependencytrack workspaces/dependencytrack/plugins/dependencytrack major v0.3.1

@ronaldtb ronaldtb mentioned this pull request Jan 16, 2025
Closed
1 task
This was referenced Jan 16, 2025
Closed
Closed
Closed
04kash
04kash reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harmenbrinkmanTRIMM, I haven’t had the chance to go through the code thoroughly yet, but I’ve pointed out a few things I noticed.

@04kash
Copy link
Member

04kash commented Jan 24, 2025

Also to get the CI to pass, you'll have to run prettier and resolve all warnings mentioned in the api report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Feb 8, 2025
@harmenbrinkmanTRIMM
Copy link
Author

Haven't had time to work on this yet. I expect to have an update in about a week or so.

@github-actions github-actions bot removed the stale label Feb 12, 2025
@harmenbrinkmanTRIMM
Copy link
Author

@04kash I've updated my branch with the improvements you've mentioned. Could you please check if all is well now? Thanks in advance :)

backstage-service and others added 10 commits February 19, 2025 16:01
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2661)
3ab8dc3 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2659)
23c5c15 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2658)
c14c540 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2657)
89aa754 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2667)
f685378 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2666)
3e8fa9a 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2665)
f3f18b0 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2664)
8f3cdf4 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@backstage-service @github-actions @harmenbrinkmanTRIMM
Version Packages (backstage#2663)
c3d0205 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@awanlin @04kash @harmenbrinkmanTRIMM
various - Removed backend import from alpha export (backstage#2644)
f14e08f 
* various - Remove backend import from alpha export

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

* mta corrections

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

---------

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Co-authored-by: Kashish Mittal <113269381+04kash@users.noreply.github.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
@harmenbrinkmanTRIMM
Copy link
Author

I'm not sure what happend, had to do a rebase because of the DCO error popping up and me forgetting to sign-off my commit. After rebasing and force updating as described by the DCO doc, all these requests for reviewers where sent out. My apologies for this.

@BethGriggs
Copy link
Collaborator

Hey @harmenbrinkmanTRIMM, it looks like your rebase picked up loads of additional commits. I'd recommend resetting to upstream/main and then cherry-picking your original commits.

If it's helpful, when I forget to sign my commits I tend to use git rebase HEAD~1 --signoff.

@harmenbrinkmanTRIMM
Copy link
Author

Hey @harmenbrinkmanTRIMM, it looks like your rebase picked up loads of additional commits. I'd recommend resetting to upstream/main and then cherry-picking your original commits.

If it's helpful, when I forget to sign my commits I tend to use git rebase HEAD~1 --signoff.

Ok thanks for the input, I'll cherry pick it then.

@harmenbrinkmanTRIMM harmenbrinkmanTRIMM deleted the migrate-dependencytrack branch February 20, 2025 15:40
@harmenbrinkmanTRIMM harmenbrinkmanTRIMM mentioned this pull request Feb 20, 2025
Closed
3 tasks
@harmenbrinkmanTRIMM
Copy link
Author

Closed this PR and opened a clean one #2962

@04kash 04kash mentioned this pull request Feb 20, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@04kash 04kash 04kash left review comments

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner automatically assigned from backstage/community-plugins-maintainers

@aljesusg aljesusg Awaiting requested review from aljesusg aljesusg is a code owner

@josunect josunect Awaiting requested review from josunect josunect is a code owner

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov christoph-jerolimov is a code owner

@ciiay ciiay Awaiting requested review from ciiay ciiay is a code owner

@debsmita1 debsmita1 Awaiting requested review from debsmita1 debsmita1 is a code owner

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar karthikjeeyar is a code owner

@Xantier Xantier Awaiting requested review from Xantier Xantier is a code owner

@schultzp2020 schultzp2020 Awaiting requested review from schultzp2020

@BethGriggs BethGriggs Awaiting requested review from BethGriggs BethGriggs is a code owner

@andrewthauer andrewthauer Awaiting requested review from andrewthauer andrewthauer is a code owner

@yashoswalyo yashoswalyo Awaiting requested review from yashoswalyo yashoswalyo is a code owner

@riginoommen riginoommen Awaiting requested review from riginoommen riginoommen is a code owner

@jkilzi jkilzi Awaiting requested review from jkilzi

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr AndrienkoAleksandr is a code owner

@PatAKnight PatAKnight Awaiting requested review from PatAKnight PatAKnight is a code owner

@kuangp kuangp Awaiting requested review from kuangp kuangp is a code owner

@JessicaJHee JessicaJHee Awaiting requested review from JessicaJHee JessicaJHee is a code owner

@jmezach jmezach Awaiting requested review from jmezach jmezach is a code owner

@dariuszsobkowicz dariuszsobkowicz Awaiting requested review from dariuszsobkowicz

@awanlin awanlin Awaiting requested review from awanlin awanlin is a code owner

@gregorytalita gregorytalita Awaiting requested review from gregorytalita gregorytalita is a code owner

@erikengervall erikengervall Awaiting requested review from erikengervall erikengervall is a code owner

@alde alde Awaiting requested review from alde alde is a code owner

@deepan10 deepan10 Awaiting requested review from deepan10 deepan10 is a code owner

@kurtaking kurtaking Awaiting requested review from kurtaking kurtaking is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.