Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release_workspace_version): prototype prior version release, add documentation #2626

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

ci(release_workspace_version): prototype prior version release, add documentation #2626

wants to merge 11 commits into from
+243 −0

Conversation

BethGriggs
Copy link
Collaborator

This is an alternative to #1175 to enable a mechanism for #860.

Some notes on this alternative approach:

  • This reuses as much as possible of the release_workspace.yml. It might be possible to combine them, but for now I've PR'd it as a separate workflow to assist in review/testing.
  • Avoids the use of workflow_dispatch, relies on branch naming and protection.

See docs/plugin-maintainers-guide.md in this PR for description of the process.

@BethGriggs BethGriggs requested a review from a team as a code owner January 30, 2025 19:30
@BethGriggs BethGriggs requested a review from vinzscam January 30, 2025 19:30
@BethGriggs
ci(release_workspace_version): prototype prior version release
1832d01 
Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
@BethGriggs
ci(release_workspace_version): add documentation
6cdeb0f 
Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
@BethGriggs
fixup! yaml
2ea2f49 
Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
@BethGriggs BethGriggs force-pushed the version-releases-alt branch from 6c2688d to 2ea2f49 Compare January 30, 2025 19:31
@BethGriggs
Copy link
Collaborator Author

@backstage/community-plugins-maintainers please take a look?

@awanlin awanlin mentioned this pull request Feb 14, 2025
Open
5 tasks
@BethGriggs
Copy link
Collaborator Author

Is there anything I can do to make this easier to review?

04kash
04kash reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and questions

BethGriggs and others added 2 commits February 20, 2025 18:15
@BethGriggs @04kash
fixup!
2e40aa1 
Co-authored-by: Kashish Mittal <113269381+04kash@users.noreply.github.com>
Signed-off-by: Bethany Griggs <bethanyngriggs@gmail.com>
@BethGriggs @04kash
fixup!
93b0a65 
Co-authored-by: Kashish Mittal <113269381+04kash@users.noreply.github.com>
Signed-off-by: Bethany Griggs <bethanyngriggs@gmail.com>
vinzscam
vinzscam approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BethGriggs
fixup!
d7307b6 
Signed-off-by: Bethany Griggs <bethanyngriggs@gmail.com>
@BethGriggs
fixup: add maintenance prefix to changesets-release, improve checks
8b86ab9 
Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
@BethGriggs
Copy link
Collaborator Author

@04kash please take a look at the last commit 8b86ab9, I think that addresses your last two comments by making the branch name more unique to avoid clashes with the releases from main, and adding some additional checks.

04kash
04kash reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed a few places where changesets-release/ would need to be changed to maintenance-changesets-release/, should be good to merge after these changes!

BethGriggs and others added 3 commits February 24, 2025 16:53
@BethGriggs @04kash
fixup!
bd70207 
Co-authored-by: Kashish Mittal <113269381+04kash@users.noreply.github.com>
Signed-off-by: Bethany Griggs <bethanyngriggs@gmail.com>
@BethGriggs @04kash
fixup!
dc97bf9 
Co-authored-by: Kashish Mittal <113269381+04kash@users.noreply.github.com>
Signed-off-by: Bethany Griggs <bethanyngriggs@gmail.com>
@BethGriggs @04kash
fixup!
fc75583 
Co-authored-by: Kashish Mittal <113269381+04kash@users.noreply.github.com>
Signed-off-by: Bethany Griggs <bethanyngriggs@gmail.com>
logonoff
logonoff reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@logonoff logonoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions regarding being extra clear in the documentation

@BethGriggs
fixup! address comments
e587138 
Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logonoff logonoff logonoff left review comments

@awanlin awanlin awanlin left review comments

@vinzscam vinzscam vinzscam approved these changes

@04kash 04kash 04kash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BethGriggs @vinzscam @logonoff @awanlin @04kash