Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin(jenkins): mark createRouter as deprecated #2992

Closed

Conversation

lcarva
Copy link

@lcarva lcarva commented Feb 25, 2025

Hey, I just made a Pull Request!

As per guidance from #1176, mark the createRouter export as deprecated. This export will be removed later on.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

As per guidance from backstage#1176, mark the createRouter export as deprecated.
This export will be removed later on.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva lcarva requested a review from a team as a code owner February 25, 2025 16:20
@lcarva lcarva requested a review from 04kash February 25, 2025 16:20
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-jenkins-backend workspaces/jenkins/plugins/jenkins-backend patch v0.11.0

@awanlin
Copy link
Contributor

awanlin commented Feb 25, 2025

Hi @lcarva, thanks for wanting to help unfortunately this was already done a few months ago here: https://github.com/backstage/community-plugins/blob/main/workspaces/jenkins/plugins/jenkins-backend/CHANGELOG.md#063 and then followed up here: https://github.com/backstage/community-plugins/blob/main/workspaces/jenkins/plugins/jenkins-backend/CHANGELOG.md#minor-changes.

The reason createRouter still exists is that it it still being used but now only internally to the plugin itself.

@lcarva
Copy link
Author

lcarva commented Feb 25, 2025

The reason createRouter still exists is that it it still being used but now only internally to the plugin itself.

@awanlin aha! I was wondering if this needed to be done for internal. Thanks for clarifying!

@lcarva lcarva closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants