Add mdx-truly-sane-lists to techdocs-core #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the discussion in backstage/backstage#6057 add mdx-truly-sane-lists to techdocs-core. This can help address some of the issues of dealing with the differences between mkdocs and commonmark/gf markdown in lists
iamEAP
reviewed
Sep 28, 2021
There was a problem hiding this comment.
Tried running this end-to-end and, as advertised, it makes lists truly sane. Thanks @jrusso1020!
Just a couple of quick items before it's mergeable:
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Signed-off-by: jrusso1020 <jrusso@brex.com>
|
@iamEAP thanks for the review! Sorry for the delay was on vacation, but believe both your comments are addressed now |
emmaindal
approved these changes
Oct 5, 2021
Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in backstage/backstage#6057
add mdx-truly-sane-lists to techdocs-core. This can help address
some of the issues of dealing with the differences between mkdocs and
commonmark/gf markdown in lists