Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn plugin diffing improvements #19

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

mtlewis
Copy link

@mtlewis mtlewis commented Nov 27, 2024

Summary

The yarn plugin is bundled and minified, and as such diffs when it is updated are not human-readable. It's relevant when the plugin changes though, and adopters might wish to see that it's changed, and in particular verify the checksum of the yarn plugin.

With this in mind, I'm proposing we:

  1. Sort .yarnrc.yml and any files in the .yarn directory to the bottom of the list
  2. Hide the diff for the yarn plugin by default, with a button allowing interested users to reveal it (similar to how large diffs are handled in GitHub diffs).

Screenshot 2024-11-27 at 14 38 15

Test Plan

What are the steps to reproduce?

Checklist

  • I tested this thoroughly
  • I added the documentation in README.md (if needed)

@mtlewis mtlewis requested review from vinzscam and a team as code owners November 27, 2024 14:43
@vinzscam
Copy link
Member

🙏

@vinzscam vinzscam merged commit d928675 into backstage:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants