Backstage master #20
Merged
Backstage master #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Co-authored-by: Adam Foxman <adam@thefoxmans.net>
previously on a comparison page like this one [1], we were having an issue, where the changelog link was not set. this was due to the package name not being accessible for the "UsefulLinks" component. this commit fixes this issue [1]: https://react-native-community.github.io/upgrade-helper/?from=0.63.4&to=0.69.0
Bumps [terser](https://github.com/terser/terser) from 4.4.3 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Sarabadu
force-pushed
the
backstage-master
branch
4 times, most recently
from
7c329d5 to
bb2c50f
Compare
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Sarabadu
force-pushed
the
backstage-master
branch
from
bb2c50f to
aa4f3bd
Compare
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Sarabadu
force-pushed
the
backstage-master
branch
from
9fe7f28 to
51bc5cf
Compare
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
vinzscam
reviewed
Jan 31, 2025
|
Thanks @vinzscam , I think settings, and home page were the most changed ones Settings related think because of the yarn plugin And home page because we changed it quite a bit and merging with theme was causing conflicts Then the change to ts bring some type issues too |
Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>
|
ok, I've added a bunch of commits, please double check. This looks awesome! 👏 |
vinzscam
approved these changes
Jan 31, 2025
|
Cool thanks for those fixes!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rebasing with latest changes from the upstream project and converting to TS
introduces dark theme and many versions bumps
working branch https://sarabadu.github.io/upgrade-helper/?from=1.34.2&to=1.35.0-next.1
Test Plan
What are the steps to reproduce?
Checklist
README.md(if needed)