-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backtrace data models serialization optimization #144
Open
BartoszLitwiniuk
wants to merge
117
commits into
master
Choose a base branch
from
backtrace-data-models-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf2711
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot files without newlines appended to them. Consider updating your IDE settings to add a newline automatically.
backtrace-library/src/main/java/backtraceio/library/common/BacktraceSerializeHelper.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceData.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceStackFrame.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceStackFrame.java
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceReport.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/test/java/backtraceio/library/TestUtils.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/test/java/backtraceio/library/TestUtils.java
Outdated
Show resolved
Hide resolved
backtrace-library/src/main/java/backtraceio/library/models/BacktraceData.java
Outdated
Show resolved
Hide resolved
perf2711
approved these changes
Oct 30, 2024
melekr
approved these changes
Oct 30, 2024
# Conflicts: # backtrace-library/build.gradle # backtrace-library/src/main/java/backtraceio/library/base/BacktraceBase.java # backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceAttributes.java # backtrace-library/src/main/java/backtraceio/library/models/json/BacktraceReport.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a comprehensive refactor of the Backtrace data models in the Android SDK. The key objectives are to enhance code maintainability, improve serialization/deserialization processes, and ensure robust unit testing.
Key Changes
BacktraceData
class and passed only once on initialization.BacktraceData
should be initialized using builder classfinal
keyword in multiple places to emphasize immutability, for safety and to improve performanceBacktraceResult
has been split into two classes,BacktraceApiResult
which parsing REST API response andBacktraceResult
is wrapper forBacktraceApiResult
with additional informations like instance of report which was sent. Processing of fieldresponse
is now improved and correctly processed inside API.Impact
This change affect all models which we are serializing and deserializing. This refactor aims to optimize performance and reliability while simplifying future development and debugging processes.
Ref: BT-2922