fix(threads): fix proc mem info data race #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR moves the mem / proc info retrieval into a separate struct with a RW mutex.
It also refactors several functions with more meaningful names.
Rationale
The current code tries to update the
Options.Attributes
in a background goroutine which is problematic, as it is concurrently being read. This can cause following error:which will cause the Go process to crash.
Updating the map separately with proper RW mutex in place seems to be the best solution to get around the problem.