Update GetDatabaseConfig.php #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add compatibility for mysql 8.0 where column-statistics is not present anymore and will cause backups to fail, this change is needed because backup manager allows extra params and it is possible to set `--column-statistics=0`, however backup-manager/laravel just passes the config from backup-manager - providing no opportunity for these extra params to be included
|
Thanks for this. =) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider adding a way to include extra params for mysqldump, this is possible in backup-manager but not laravel:
// add additional options to dump-command (like '--max-allowed-packet')'extraParams' => '--column-statistics=0',My pull request has
'--column-statistics=0'hard coded for reasons detailed below, however I suggest that this should not be hard coded - provide a way for these values to be specified, possibly with another config file/array;'extraParams' => $connection['extraParams'],?