Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up/down arrows in Chris mode #152

Closed
Vospi opened this issue Aug 31, 2024 · 8 comments · Fixed by #153 or #162
Closed

Up/down arrows in Chris mode #152

Vospi opened this issue Aug 31, 2024 · 8 comments · Fixed by #153 or #162

Comments

@Vospi
Copy link

Vospi commented Aug 31, 2024

Hey there!
Not really a big issue, but:

  • if you switch to Chris Order Menus, up/down arrows still seem to work through an alphabetical one, so you can't explore the Chris sorting with the arrows on the interface, only going through the menu.

Windows, ver Aug 24 2024.

Thanks for the wonderful work! Amazing way to really dig into Airwindows.

@baconpaul
Copy link
Owner

Oh yeah wow i can see why that would be.

Let me add it to my 'todo' list for the next couple of weeks. Thanks!

baconpaul added a commit that referenced this issue Sep 2, 2024
If you are in "Chris" order and in the juce plugin you
now have jogs consistent with menu.

Closes #152
@baconpaul
Copy link
Owner

Hey! I got a bit of time and put this in. Next build in an hour or so should have it

@Vospi
Copy link
Author

Vospi commented Sep 2, 2024

Love this! Thank you!

@Vospi
Copy link
Author

Vospi commented Sep 3, 2024

Hey! I've just updated to 8989ff1, CLAP on Windows, and the sorting works the same.
To clarify:

  1. I am in "Chris (Quality) Order Menus"
  2. For example, I select Ambience -> Clear Coat from the top of my text list.
  3. Then I press a "down" arrow on the interface and expect to get TapeDelay2, the next in "Chris Order". However, I get Doublelay, the next in alphabetical order.

The dropdown menus themselves are fine and were fine for me before.

(The plugin is still very useful, thought-out and beautiful!)

@baconpaul
Copy link
Owner

Hmm I see the exact opposite. That exact test works for me.

Not to be rude but are you sure you are running the updated version? The settings / about menu will show you the build date and hash.

Also are you on collection "All" (although I tried it in other collections too)

@Vospi
Copy link
Author

Vospi commented Sep 3, 2024

I completely understand! No worries.
The plugin says the name of the build I've posted, I made sure before the last post, should've noted that previously :) Sep 2 2024 8989ff1, the window says.

My sorting settings are:
Filter by collection - All Plugins
Show Documentation
Christ (Quality) Order Menus

Doesn't work.
I've tried it in the Basic collection as well.
Also, I somehow have 4 collections? Latest, Basic, Latest and Recommended. Yes, Latest is there 2 times, not a typo

@baconpaul
Copy link
Owner

Yeah I saw that double latest today
That’s just generated from Chris input so I bet he added a trailing space somewhere and I don’t strip it

ok let me reopen. I don’t understand why it would work for me and not you but I can look again this week

@baconpaul baconpaul reopened this Sep 3, 2024
baconpaul added a commit that referenced this issue Oct 2, 2024
@baconpaul
Copy link
Owner

oh sheesh i realize that (1) i forgot to look at this and (2) when i realized that now and look that I just hadn't committed the code that makes this fix.

I'm so sorry the fix was just uncommitted on my hard drive for a month neglected and forgotten. Should be in a nightly in an hour or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants