Use xdg-open instead of assuming Nautilus for Linux #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badabing2005
approved these changes
Aug 28, 2024
|
Thanks. |
badabing2005
added a commit
that referenced
this pull request
Aug 29, 2024
… APatch app for patching, manual APatch patching is recommended. PixelFlasher automates this manual process—just select `Patch with APatch Alternate`. You’ll be prompted to choose between the latest release or the latest pre-release of Kernel Patch tools. - **APatch Validation**: Added validation for APatch patching to ensure the kernel is a supported version and that `CONFIG_KALLSYMS` is enabled. - **Homebrew Cask Support**: Added a Homebrew cask install option for macOS, ensuring automatic updates. Use the command: `brew install badabing2005/pixelflasher/pixelflasher`. - **PR Merge #239**: On Linux, PixelFlasher now uses `xdg-open` (if available) instead of Nautilus, thanks to @aarjaneiro. - **16K Page Size Preparation**: In preparation for the upcoming 16K page size feature in Android, PixelFlasher now reports the current page size. - **Miscellaneous**: Various minor improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also could instead add a call to set a constant outside of this function to determine the status of
which xdg-openrather than having this be retested every timeopen_folderis called.