Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fix issues/instructions when compiling for OpenWrt #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kerta1n
Copy link

@kerta1n kerta1n commented Dec 29, 2023

Update make command so that make does not compile for ALL packages, but just snapcast. Users may end up wasting processing power by compiling packages that are already compiled into packages by the OpenWrt team.

Update make command
Commenting out line #112 gets rid of an error when compiling using the instructions in openwrt/snapcast/README.md.
@kerta1n kerta1n changed the title Update README.md Fix issues/instructions when compiling OpenWrt Dec 29, 2023
@kerta1n kerta1n changed the title Fix issues/instructions when compiling OpenWrt Fix issues/instructions when compiling for OpenWrt Dec 29, 2023
@kerta1n
Copy link
Author

kerta1n commented Dec 29, 2023

A FIX WHILE THIS PR IS OPEN:
As of (end of) this year, 23.05.2 is the latest release. Using the instructions from the current README results in compiling ALL packages for OpenWrt, AND THEN Snapcast. It's advised that in order to save time and ONLY compile a Snapcast .ipk, one should use make package/snapcast/compile in the <wrt-sdk> directory, and before that, comment out line 112 in the Makefile. Then continue instructions from there.
EDIT: seems issue #27 got to this solution first.

davidandreoletti added a commit to davidandreoletti/openwrt-snapcast that referenced this pull request Mar 13, 2024
davidandreoletti added a commit to davidandreoletti/openwrt-snapcast that referenced this pull request Mar 13, 2024
davidandreoletti added a commit to davidandreoletti/openwrt-snapcast that referenced this pull request Mar 13, 2024
davidandreoletti added a commit to davidandreoletti/openwrt-snapcast that referenced this pull request Mar 14, 2024
@davidandreoletti
Copy link
Contributor

@badaix This PR should be closed since #29 is merged in.

@kerta1n
Copy link
Author

kerta1n commented Apr 4, 2024

Willing to link my 16c server to GitHub actions if needed to build packages 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants