Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add vanilla crop and tree sapling growability tooltip #245

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Attempt to add vanilla crop and tree sapling growability tooltip #245

merged 7 commits into from
Jan 4, 2024

Conversation

CrimsonEdgeHope
Copy link
Contributor

#220 #243

  • Attempt to add vanilla tree sapling growability tooltip. (As a matter of fact, such detection simply relies on brightness, feasible for only vanilla items)
  • New translation keys.

1

Credit to @Davideko212 for prior changes.

Davideko212 and others added 5 commits November 24, 2023 18:12
Exception occurred whilst testing.  java.lang.ClassCastException: class java.lang.Double cannot be cast to class java.lang.Integer
Copy link
Member

@deirn deirn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some styling issues, other than that it looks good.

CrimsonEdgeHope and others added 2 commits December 21, 2023 04:41
Co-authored-by: deirn <deirn@bai.lol>
@CrimsonEdgeHope CrimsonEdgeHope marked this pull request as ready for review December 21, 2023 05:11
@deirn deirn merged commit 94da3ed into badasintended:dev/master Jan 4, 2024
1 check passed
deirn pushed a commit that referenced this pull request Jan 4, 2024
* Add crop growability tooltip

* Update de_de.json

* minor fix

Exception occurred whilst testing.  java.lang.ClassCastException: class java.lang.Double cannot be cast to class java.lang.Integer

* Add crop growability tooltip

* Add tree growability tooltip

* Update PlantProvider.java

Co-authored-by: deirn <deirn@bai.lol>

* styling

---------

Co-authored-by: Davideko <david.koch.email@gmail.com>
Co-authored-by: deirn <deirn@bai.lol>
(cherry picked from commit 94da3ed)
deirn pushed a commit that referenced this pull request Jan 4, 2024
* Add crop growability tooltip

* Update de_de.json

* minor fix

Exception occurred whilst testing.  java.lang.ClassCastException: class java.lang.Double cannot be cast to class java.lang.Integer

* Add crop growability tooltip

* Add tree growability tooltip

* Update PlantProvider.java

Co-authored-by: deirn <deirn@bai.lol>

* styling

---------

Co-authored-by: Davideko <david.koch.email@gmail.com>
Co-authored-by: deirn <deirn@bai.lol>
(cherry picked from commit 94da3ed)
deirn pushed a commit that referenced this pull request Jan 4, 2024
* Add crop growability tooltip

* Update de_de.json

* minor fix

Exception occurred whilst testing.  java.lang.ClassCastException: class java.lang.Double cannot be cast to class java.lang.Integer

* Add crop growability tooltip

* Add tree growability tooltip

* Update PlantProvider.java

Co-authored-by: deirn <deirn@bai.lol>

* styling

---------

Co-authored-by: Davideko <david.koch.email@gmail.com>
Co-authored-by: deirn <deirn@bai.lol>
(cherry picked from commit 94da3ed)
@CrimsonEdgeHope CrimsonEdgeHope deleted the p3 branch January 5, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants