Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: step definitions never get's reloaded #1

Closed
NoNameProvided opened this issue Jan 9, 2018 · 8 comments
Closed

bug: step definitions never get's reloaded #1

NoNameProvided opened this issue Jan 9, 2018 · 8 comments

Comments

@NoNameProvided
Copy link

When using npx cypress open to write tests, it would be great to have auto-updated step definitions. Now they are loaded only once on start only so I need to re-run cypress every time what is very slow.

@eaustin
Copy link

eaustin commented Jan 15, 2018

I believe have the same problem.

@NoNameProvided
Copy link
Author

NoNameProvided commented Jan 15, 2018

I made the *.feature files reload and I have a few other improvements as well, I will fire up a gist with it soon.

In the meantime you can watch NoNameProvided/cypress-cucumber-preprocessor I need it for work, so I will turn it into something usable in the close future. (now it's just a placeholder repo).

@NoNameProvided
Copy link
Author

NoNameProvided commented Jan 15, 2018

Here is the gist: https://gist.github.com/NoNameProvided/14ba8dee2529de258804454d2c3c99c8

The step definition files are still not reloaded, but the step files (.feature) files are and should update as soon as you save them.

@fcurella
Copy link
Contributor

Hi,

I've got this working with features and step definitions reload. Should I send a PR to NoNameProvided/cypress-cucumber-preprocessor or here?

@lgandecki
Copy link
Collaborator

@fcurella I'd love to add your contribution here and give you the credit deserved, would you be so kind to fork this one, paste your changes over the files in this repo and create another PR? I've just tried to use your fork but since it has a different commit history, github won't allow me to compare/merge this properly :(

@fcurella
Copy link
Contributor

@lgandecki sorry about the confusion, I had the impression that you and @NoNameProvided were working together. I'll close the original PR and submit it here.

Repository owner deleted a comment from NoNameProvided Jan 23, 2018
Repository owner deleted a comment from NoNameProvided Jan 23, 2018
Repository owner deleted a comment from NoNameProvided Jan 23, 2018
@lgandecki
Copy link
Collaborator

I removed the out of the topic discussion. You don't have to use this NoName, you are right. I never asked you. I only ask you to respect my work and don't steal it or bash it with no arguments (happy to see how you made things better, when you finally decide to enlighten us).

@fcurella thanks, I will review this during the next 24 hrs :-) I already looked briefly but I want to test and understand exactly what you've changed and how it works first.

@cicely-f
Copy link

I'm running Cypress 3.0.1 and the latest version of this plugin. The step definitions are still not reloaded, and I am forced to close and restart Cypress to get the updated steps to run.

To reproduce:

  1. write a feature file with several Given, When, Then steps
  2. write corresponding step definition, implementing only the Given
  3. see error message about missing step implementation when running Cypress
  4. implement the When step
  5. watch Cypress re-run the apparently previous version of the step definition, since it returns the same error message as in step 3
  6. close and reopen Cypress
  7. see that the error message changes to missing implementation of the Then step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants