Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a way to add some additional params to redirect url #116

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

pks1989
Copy link
Contributor

@pks1989 pks1989 commented Jul 28, 2023

Hi! I very like you library for lightweight. But custom auth server in my company wants to have some specific user info form redirect URL. Like deviceId, analytics systems id and other. And i don't see possibility do that with this lib.

@pks1989 pks1989 changed the title create way to add some additional params to redirect url create a way to add some additional params to redirect url Jul 28, 2023
Copy link
Collaborator

@evert evert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unittests would also be very welcome for this. It will make it easier for me to quickly merge and publish.

src/client/authorization-code.ts Outdated Show resolved Hide resolved
@pks1989 pks1989 requested a review from evert July 31, 2023 12:56
It's not a core use-case, and it's nice to keep the readme a bit minimal.
@evert evert enabled auto-merge August 3, 2023 02:38
@evert
Copy link
Collaborator

evert commented Aug 3, 2023

Looks good! just some lint errors now

auto-merge was automatically disabled August 3, 2023 08:49

Head branch was pushed to by a user without write access

@pks1989 pks1989 requested a review from evert August 3, 2023 08:53
@pks1989
Copy link
Contributor Author

pks1989 commented Aug 7, 2023

Looks good! just some lint errors now

Fixed :) All green now

@evert evert merged commit 588c23b into badgateway:main Aug 9, 2023
@pks1989 pks1989 deleted the add_custom_params_to_auth_uri branch August 10, 2023 09:42
@motnyk
Copy link

motnyk commented Sep 5, 2023

👋 @evert, just checking if you have any plans to release a 2.2.4 version of the client with this change anytime soon?

@evert
Copy link
Collaborator

evert commented Sep 5, 2023

Lets do it!

@evert
Copy link
Collaborator

evert commented Sep 5, 2023

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants