Upgrade Sentry to v8 and switch to IS_YSTV_BUILD #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 19.57% 19.62% +0.05%
==========================================
Files 95 95
Lines 3433 3439 +6
Branches 590 601 +11
==========================================
+ Hits 672 675 +3
+ Misses 2760 2617 -143
- Partials 1 147 +146 ☔ View full report in Codecov by Sentry. |
|
/yarn unlock |
2 similar comments
|
/yarn unlock |
|
/yarn unlock |
|
Trying to merge yarn.lock... follow along at https://github.com/ystv/badger/actions/runs/9881563878 |
|
/yarn unlock |
|
No conflicts found. |
|
/yarn unlock |
|
Something went wrong. Please look at the logs. |
|
/yarn unlock |
|
Something went wrong. Please look at the logs. |
|
/yarn unlock |
|
Something went wrong. Please look at the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Sentry SDK to v8 and applies some of their breaking changes.
It also renames the
IS_PRODUCTION_BUILDenvironment variable toIS_YSTV_BUILDto more accurately reflect its purpose, and updates the Desktop build process to respect it as well. This will become important if non-YSTV users start to use Badger - we don't want them to get our Sentry config for privacy reasons. We may want to re-evaluate this later once we have a more robust opt-out system, but for now just disable Sentry for non-YSTV builds.Resolves BDGR-171