Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BDGR-179] Remove YSTV login #484

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

markspolakovs
Copy link
Collaborator

It's janky and unused by anyone (including YSTV).

Note that this keeps around username/password login, as it's still used in E2E tests, however it doesn't implement an username/password authentication backend - the only supported ones are Google and Dummy Test Auth. If there's demand we might consider adding a local user database.

Fixes BDGR-179.

@markspolakovs markspolakovs added this to the Public-isation milestone Jul 9, 2024
@markspolakovs markspolakovs enabled auto-merge July 9, 2024 21:18
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.28%. Comparing base (79b5353) to head (1427cb8).
Report is 66 commits behind head on main.

Files Patch % Lines
server/app/login/@local/form.tsx 0.00% 2 Missing ⚠️
server/app/login/@local/page.tsx 0.00% 1 Missing ⚠️
server/app/login/layout.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #484       +/-   ##
==========================================
+ Coverage   3.06%   22.28%   +19.21%     
==========================================
  Files         88       95        +7     
  Lines       2548     3595     +1047     
  Branches     546      604       +58     
==========================================
+ Hits          78      801      +723     
- Misses      2470     2647      +177     
- Partials       0      147      +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markspolakovs markspolakovs added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit f9b03b7 Jul 9, 2024
14 checks passed
@markspolakovs markspolakovs deleted the bdgr-179-remove-ystv-login branch July 9, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants