Week 6: Add sound for send-message and toggle button #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaiapalacios
changed the title
|
I like the sounds a lot! And it works great! I'm just getting a warning on my console: I tried moving the imports and the useSound hook to the navbar instead of the context file and it still works and I didn't get a warning. |
|
Thanks, Vini, for the input. I'll go ahead and make those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #160
Note: made edits based on feedback. PR is no longer for testing purposes. Seeking testing & approval to merge to our main branch.
For setup, run:
npm install use-sound