Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prerelease SemvVer tags are wrongly detected as newer than the release #1622

Closed
ghost opened this issue Mar 29, 2018 · 9 comments · Fixed by #1628
Closed

prerelease SemvVer tags are wrongly detected as newer than the release #1622

ghost opened this issue Mar 29, 2018 · 9 comments · Fixed by #1628

Comments

@ghost
Copy link

ghost commented Mar 29, 2018

  • prerelease: v8.77.25-alpha.1
  • release: v8.77.25

The shied on the readme should display the first instead of the latter.

@paulmelnikow
Copy link
Member

Hi! Which badge are you referring to? Is the problem still observable with that package?

@ghost
Copy link
Author

ghost commented Mar 29, 2018

sorry, issue was not well formulated. I'll reopen with a concret example.

@ghost ghost closed this as completed Mar 29, 2018
@SuperSandro2000
Copy link

You know you can edit issues?

@ghost ghost reopened this Mar 30, 2018
@ghost
Copy link
Author

ghost commented Mar 30, 2018

Concrete example, look (ASAP since it may change soon) at the badge here https://github.com/dlang/phobos/blob/master/README.md. and now the tags: https://github.com/dlang/phobos/releases.

@RedSparr0w
Copy link
Member

On mobile right now so can't look into it properly, but for anyone else looking into this issue:
I believe this is due to the way GitHubs api sends the data through (alphabetical order) rather than by date released (this is from memory of another similar issue relating to tags).

@ghost
Copy link
Author

ghost commented Mar 30, 2018

It's also about how the SemVer is interpreted i think. I use a library, for example, that's aware of the common -alpha.<n>, -beta.<n> and finally -rc.<n> suffixes, and assert(SemVer("1.0.0-beta.1") < SemVer("1.0.0")) works.

@RedSparr0w
Copy link
Member

it looks like it fails fails due to not providing a strictly valid semver version 2.079.0 should be 2.79.0,
Will create a PR patching this soon.

@ghost
Copy link
Author

ghost commented Mar 31, 2018

Yes but while this is is right for this one i had the same issue with a repo with a valid SemVer.

@RedSparr0w
Copy link
Member

If you could provide an example repo I can investigate further.

@ghost ghost closed this as completed May 18, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants