loosely detect semver versions #1628

RedSparr0w · 2018-03-31T03:27:28Z

Closes #1622
Closes #1652
Closes #1682
refer: https://www.npmjs.com/package/semver#functions

All methods and classes take a final loose boolean argument that, if true, will be more forgiving about not-quite-valid semver strings. The resulting output will always be 100% strict, of course.

This PR will allow "not-quite-valid semver strings" example: 1.023.4, 1.23

semver.valid('1.023.4') // null
semver.valid('1.023.4', true) // '1.23.4'
semver.maxSatisfying(['v2.079.0', 'v2.079.0-rc.1'], '') // TypeError: Invalid Version: v2.079.0
semver.maxSatisfying(['v2.079.0', 'v2.079.0-rc.1'], '', true) // 'v2.079.0'

Note:

Only the change on line 21 is needed to close #1622, but figured we should add support for the other places these functions are used also.

Note2/Edit:

versions = ['v1.2.3-beta', 'v1.2.3-alpha'];
semver.maxSatisfying(versions, '') // null
semver.maxSatisfying(versions, '', true) // null
versions.sort((a, b) => {
  semver.compare(a, b, true);
})[0]; // 'v1.2.3-beta'

shields-ci · 2018-03-31T03:28:17Z

	Warnings
⚠️	This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

	Messages
📖	✨ Thanks for your contribution to Shields, @RedSparr0w!

Generated by 🚫 dangerJS

paulmelnikow

Honestly I haven't concluded whether or not this is the right thing to do, though I thought I would nudge this forward with a review comment.

paulmelnikow · 2018-04-02T02:42:18Z

lib/version.js

@@ -18,11 +18,13 @@ function latest(versions) {
    return (/[0-9]/).test(version);
  });
  try {
-    version = semver.maxSatisfying(versions, '');
+    version = semver.maxSatisfying(versions, '', true) || versions.sort((a, b) => {


Could we write these calls like maxSatisfying(versions, /* range */ '', /* loose */ true) to make it clearer what these parameters are? Same for the other uses of the loose parameter.

Sounds good!

Have updated to include the /* loose */ true comments, but it does look a little messy.
Do you think it would be better to do something like:

const semverLoose = true; version = maxSatisfying(versions, /* range */ '', semverLoose);

const loose = true; const range = ''; version = maxSatisfying(versions, range, loose);

RedSparr0w · 2018-04-19T02:25:48Z

Updated to first only compare all "semver" versions (1.2, 1.2.3 etc.) /\d+\.\d+/
If none are found it will check for any single number versions (1, 2, 3)

both could still fail if there are any strange versions like 18w11a which i believe would be interpreted as 18.0.0.

If that fails then it will just be alphabetically sorted as before.

Edit: this also closes #1652

comments refered to incorrect test

badges#1682

RedSparr0w · 2018-05-11T06:54:40Z

Updated to also include a fix for #1682
Supporting pre-release versions.
eg: v1.0.1-alpha.1 > v1.0.0 (previously it would not pick this up as being newer)

RedSparr0w · 2018-06-17T23:24:12Z

Updated to make pre-release versions opt in as per @paulmelnikow comment

paulmelnikow · 2018-07-20T02:53:04Z

lib/version.js

@@ -11,18 +11,31 @@ const semver = require('semver');

 // Given a list of versions (as strings), return the latest version.
 // Return undefined if no version could be found.
-function latest(versions) {
+function latest(versions, pre = false) {


Could we make this an object?

function latest(versions, { pre = false } = {}) {

That way, when it's invoked, the parameter can be named, too.

Updated!
👍

paulmelnikow · 2018-07-20T03:03:33Z

lib/version.js

+  if (!pre){
+    versions = versions.filter(function(version) {
+      return !(/\d+-\w+/).test(version);
+    });


This is a bit difficult to follow.

I understand the purpose served by filtering out the prereleases. Could you explain what the rest of the filtering is for? Would it not work to just pass the other versions to the loose compare function?

I have the \d+\.\d+ test first to get what we would assume is definitely a version.
If that returns no results, we fall back to just look for anything that could possibly be a version.

Otherwise in an array of:

["abc123f312", "1.2.3", "1.3"]

abc123f312 would be the newest version as it's interpreted as 123

paulmelnikow · 2018-07-20T03:05:45Z

server.js

-  var format = match[2];
-  var apiUrl = 'https://pub.dartlang.org/packages/' + userRepo + '.json';
-  var badgeData = getBadgeData('pub', data);
+  const includePre = Boolean(match[1]);


RedSparr0w · 2018-07-24T01:43:04Z

Think this should be ready for merge now!
🤞

shields-deployment · 2018-07-26T20:27:51Z

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

from PR badges/shields#1628

RedSparr0w added 2 commits March 31, 2018 16:23

loosely detect semver versions

beaf7a6

semver loose validity

ec57414

RedSparr0w added 2 commits March 31, 2018 16:32

add test

b6da472

semver compare versions when null

bce5909

paulmelnikow reviewed Apr 2, 2018

View reviewed changes

paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Apr 2, 2018

RedSparr0w added 3 commits April 5, 2018 10:09

add comments for loose

f75b381

remove console.log, only match semver scheme

4240fa6

looser version restrictions

5f3a55e

RedSparr0w mentioned this pull request Apr 19, 2018

Github tag badge - 'untagged' tag trumps numeric tag #1652

Closed

chris48s mentioned this pull request May 10, 2018

GitHub tag: wrong value displayed on badge #1682

Closed

RedSparr0w added 2 commits May 11, 2018 18:33

re-sort version tests

ec31842

comments refered to incorrect test

add support for pre-release tags

e2aea5d

badges#1682

This was referenced Jun 2, 2018

Packagist version badges not being updated #1586

Closed

[packagist] use semver latestVersion #1717

Closed

RedSparr0w added 2 commits June 5, 2018 10:12

support uppercase, lowercase mixed

c09fa8e

make pre-release opt in

19192b5

paulmelnikow reviewed Jul 20, 2018

View reviewed changes

paulmelnikow mentioned this pull request Jul 20, 2018

Turn on prettier (except repo root) #1167

Merged

3 tasks

RedSparr0w added 2 commits July 24, 2018 13:30

change pre param to object

1051cd1

add notes

f333934

paulmelnikow approved these changes Jul 26, 2018

View reviewed changes

RedSparr0w merged commit 329db7d into badges:master Jul 26, 2018

slodki added a commit to slodki/moneymanagerex that referenced this pull request Aug 15, 2018

fix(moneymanagerex#1651): use fixed upstream release of shields.io

8d316da

from PR badges/shields#1628

slodki mentioned this pull request Aug 15, 2018

fix(#1651): use fixed upstream release of shields.io moneymanagerex/moneymanagerex#1757

Merged

slodki added a commit to moneymanagerex/moneymanagerex that referenced this pull request Aug 15, 2018

fix(#1651): use fixed upstream release of shields.io

13cf98c

from PR badges/shields#1628

RedSparr0w mentioned this pull request Sep 27, 2018

Github tag not showing the correct value #2117

Closed

chris48s mentioned this pull request Oct 1, 2018

Semver tags not updating for /github/tag #875

Closed

RedSparr0w deleted the 1622-fix branch January 21, 2019 03:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

loosely detect semver versions #1628

loosely detect semver versions #1628

RedSparr0w commented Mar 31, 2018 •

edited

Loading

shields-ci commented Mar 31, 2018 •

edited

Loading

paulmelnikow left a comment

paulmelnikow Apr 2, 2018

RedSparr0w Apr 2, 2018

RedSparr0w Apr 4, 2018

RedSparr0w commented Apr 19, 2018 •

edited

Loading

RedSparr0w commented May 11, 2018

RedSparr0w commented Jun 17, 2018

paulmelnikow Jul 20, 2018

RedSparr0w Jul 24, 2018

paulmelnikow Jul 20, 2018

RedSparr0w Jul 23, 2018

paulmelnikow Jul 20, 2018

RedSparr0w commented Jul 24, 2018

shields-deployment bot commented Jul 26, 2018

loosely detect semver versions #1628

loosely detect semver versions #1628

Conversation

RedSparr0w commented Mar 31, 2018 • edited Loading

Note:

Note2/Edit:

shields-ci commented Mar 31, 2018 • edited Loading

paulmelnikow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedSparr0w commented Apr 19, 2018 • edited Loading

RedSparr0w commented May 11, 2018

RedSparr0w commented Jun 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedSparr0w commented Jul 24, 2018

shields-deployment bot commented Jul 26, 2018

RedSparr0w commented Mar 31, 2018 •

edited

Loading

shields-ci commented Mar 31, 2018 •

edited

Loading

RedSparr0w commented Apr 19, 2018 •

edited

Loading