Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub tag: wrong value displayed on badge #1682

Closed
slodki opened this issue May 10, 2018 · 6 comments · Fixed by #1628
Closed

GitHub tag: wrong value displayed on badge #1682

slodki opened this issue May 10, 2018 · 6 comments · Fixed by #1628
Labels
bug Bugs in badges and the frontend

Comments

@slodki
Copy link

slodki commented May 10, 2018

Please compare badge with GitHub API returned values

v1.4.0-alpha.4 should be displayed as the latest version tag.
@slodki slodki changed the title GitHub tag: vrong value displayed on badge GitHub tag: wrong value displayed on badge May 10, 2018
@slodki slodki mentioned this issue May 10, 2018
Closed
@chris48s
Copy link
Member

@RedSparr0w - is this the same issue that you're looking at in #1628 ?

@slodki
Copy link
Author

slodki commented May 10, 2018 •
edited
Loading

All tags returned by GH API are valid semvers, I'm not sure #1628 will help.
BTW: GH API for tags is filtering semver compatible tags - "nightly" tag value is not returned (https://github.com/moneymanagerex/moneymanagerex/tags)

RedSparr0w added a commit to RedSparr0w/shields that referenced this issue May 11, 2018
@RedSparr0w
add support for pre-release tags
e2aea5d 
badges#1682
@RedSparr0w RedSparr0w mentioned this issue May 11, 2018
Merged
@RedSparr0w
Copy link
Member

RedSparr0w commented May 11, 2018 •
edited
Loading

@chris48s Was fairly similar, have updated to include this issue also.

Edit: also see npm/node-semver#216 for an explanation on why it works this way by default with maxSatisfying()

@chris48s chris48s added the bug Bugs in badges and the frontend label May 11, 2018
@paulmelnikow
Copy link
Member

Is this definitely the behavior we want? Many of our other version badges ignore prereleases.

I see that #1628 includes a modification to accommodate this, though I wonder if in this case, we should default to ignoring prereleases, and let developers choose if they want to see them.

RedSparr0w added a commit that referenced this issue Jul 26, 2018
@RedSparr0w
loosely detect semver versions (#1628)
329db7d 
* loosely detect semver versions

* semver loose validity

* add test

* semver compare versions when null

* add comments for loose

* remove console.log, only match semver scheme

* looser version restrictions

* re-sort version tests

comments refered to incorrect test

* add support for pre-release tags

#1682

* support uppercase, lowercase mixed

* make pre-release opt in

* change pre param to object

* add notes
@slodki
Copy link
Author

slodki commented Aug 15, 2018

Thx

@RedSparr0w
Copy link
Member

Usage:
https://img.shields.io/github/tag-pre/moneymanagerex/moneymanagerex.svg

@RedSparr0w RedSparr0w mentioned this issue Sep 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bugs in badges and the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

loosely detect semver versions RedSparr0w/shields
4 participants
@paulmelnikow @slodki @chris48s @RedSparr0w