Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

danger bot: add msg when new badge is added #2015

Open
tooomm opened this issue Aug 29, 2018 · 1 comment
Open

danger bot: add msg when new badge is added #2015

tooomm opened this issue Aug 29, 2018 · 1 comment
Labels
developer-experience Dev tooling, test framework, and CI

Comments

@tooomm
Copy link
Contributor

tooomm commented Aug 29, 2018

Same as for new logos
https://github.com/badges/shields/blob/master/dangerfile.js#L86-L93
have a case for newly added badges/services.

As seen in #1965 there is no dedicated message currently.

What could be put there?

  • Include a link to the tutorial or the later sections of it
  • check if badge is exposed to the frontend
  • check if tests exist (not sure if danger detects that as is for freshly added services)
@chris48s chris48s added the developer-experience Dev tooling, test framework, and CI label Sep 2, 2018
@dependabot-preview dependabot-preview bot mentioned this issue Dec 31, 2018
Merged
@paulmelnikow
Copy link
Member

This is a good idea. Is anyone up for taking this on?

@BryanLaura BryanLaura mentioned this issue Jun 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulmelnikow @chris48s @tooomm