Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove remaining uses of urlPattern #2334

Closed
chris48s opened this issue Nov 17, 2018 · 0 comments
Closed

remove remaining uses of urlPattern #2334

chris48s opened this issue Nov 17, 2018 · 0 comments
Labels
core Server, BaseService, GitHub auth, Shared helpers good first issue New contributors, join in!

Comments

@chris48s
Copy link
Member

follow-up from #2308
@chris48s chris48s added the core Server, BaseService, GitHub auth, Shared helpers label Nov 17, 2018
@paulmelnikow paulmelnikow added the good first issue New contributors, join in! label Nov 17, 2018
@paulmelnikow paulmelnikow mentioned this issue Nov 17, 2018
Merged
paulmelnikow added a commit that referenced this issue Nov 18, 2018
@paulmelnikow
Example: Canonicalize urlPattern to pattern (#2341)
3ad742e 
Close #2334 

To avoid merge conflicts, I've deferred removing the aliasing logic in `prepareExamples`. That whole function will be refactored momentarily, and there's also #2339 open.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers good first issue New contributors, join in!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmelnikow @chris48s