Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path in modal should work with URL base #2495

Closed
1 of 3 tasks
chris48s opened this issue Dec 9, 2018 · 2 comments
Closed
1 of 3 tasks

Path in modal should work with URL base #2495

chris48s opened this issue Dec 9, 2018 · 2 comments
Labels
bug Bugs in badges and the frontend frontend The Docusaurus app serving the docs site

Comments

@chris48s
Copy link
Member

chris48s commented Dec 9, 2018

Are you experiencing an issue with...

🪲 Description

Since deploying #2441 to production, the 'path' field expects the content not to have a URL base set, but we use one everywhere else:

this doesn't work:

screenshot at 2018-12-09 16-36-37

you have to do this to get a preview to render:

screenshot at 2018-12-09 16-37-10

This was difficult to pick up on staging because there is no base set.

@chris48s chris48s added frontend The Docusaurus app serving the docs site bug Bugs in badges and the frontend labels Dec 9, 2018
@paulmelnikow
Copy link
Member

Ah, hmm. I mentioned this change in the PR. Local dev looks like production. I didn't realize staging looked so different.

To be honest, I feel like the long URLs everywhere have to go. They make the page look incredibly busy:

screen shot 2018-12-09 at 8 18 44 pm

I suppose you copied and pasted the example URL into the Path box and expected it to render. Is that right?

If so, I wonder if this can be made clearer. I have an idea about a possible solution.

Reverting the behavior is a possibility too.

@paulmelnikow
Copy link
Member

After discussing offline we decided to hold off on changing this given the changes in #2496 will wipe out this part of the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend frontend The Docusaurus app serving the docs site
Projects
None yet
Development

No branches or pull requests

2 participants