Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI test summary broken on daily-tests #3054

Closed
paulmelnikow opened this issue Feb 20, 2019 · 3 comments
Closed

CircleCI test summary broken on daily-tests #3054

paulmelnikow opened this issue Feb 20, 2019 · 3 comments
Assignees
@calebcartwright
Labels
developer-experience Dev tooling, test framework, and CI

Comments

@paulmelnikow
Copy link
Member

Some time between https://circleci.com/gh/badges/daily-tests/159 and https://circleci.com/gh/badges/daily-tests/160, the test summary stopped working on the daily-tests. The failures for services don't show up, and main is showing 77 passed tests but several missing failures.

Maybe related to a dependency bump? Or the Mocha config change?
@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Feb 20, 2019
@calebcartwright
Copy link
Member

bummer. i'll take a look at this one

@calebcartwright calebcartwright self-assigned this Feb 20, 2019
@calebcartwright
Copy link
Member

calebcartwright commented Feb 20, 2019 •
edited
Loading

So this may be a stretch, but the Mocha docs/v6 release notes enumerate which config files will be loaded automatically, and all the values listed are dot files

https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#tada-enhancements-1
https://mochajs.org/#configuring-mocha-nodejs

However, our root level mocha rc file is mocharc.yml so I'm wondering how pedantic mocha's new auto-config loader is about dot vs. not dot

I'm setting up a small local project to test that out

@calebcartwright
Copy link
Member

calebcartwright commented Feb 20, 2019 •
edited
Loading

Yup! https://github.com/mochajs/mocha/blob/master/lib/cli/config.js#L23 and confirmed in my own local env.

I'm honestly really surprised by this, but oh well. I'll open a PR to rename ours to .mocharc.yml unless anyone strongly prefers the alternative where we'd have to add --config mocharc.yml to all our npm scripts running tests

@calebcartwright calebcartwright mentioned this issue Feb 20, 2019
Merged
paulmelnikow pushed a commit that referenced this issue Feb 20, 2019
@calebcartwright @paulmelnikow
chore: make mocha rc configs dotfiles (#3065)
96d48dc 
Fixes #3054 

Apparently mocha 6's new auto-config discovery only works with dotfiles. This renames our mocha rc files accordingly: `mocharc.yml` --> `.mocharc.yml` and solely to be consistent `mocharc-frontend.yml` --> ` .mocharc-frontend.yml`

- https://github.com/mochajs/mocha/blob/master/lib/cli/config.js#L23
- https://mochajs.org/#configuring-mocha-nodejs
- https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#tada-enhancements-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebcartwright calebcartwright

Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmelnikow @calebcartwright