Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge request: GitHub NPM package.json - optionalDependencies #6044

Closed
the-homeless-god opened this issue Jan 9, 2021 · 5 comments · Fixed by #6749
Closed

Badge request: GitHub NPM package.json - optionalDependencies #6044

the-homeless-god opened this issue Jan 9, 2021 · 5 comments · Fixed by #6749
Labels
good first issue New contributors, join in! service-badge New or updated service badge

Comments

@the-homeless-god
Copy link

📋 - optionalDependencies from NPM package.json at GitHub need be supported like it supported dependencies and devDependencies.

Example of view: dependencyName: version.

🔗 - similar to the getting of GitHub package.json devDependencies and dependencies

🎤 - by default badges demonstrates packages that required to use, but optionalDependencies will provide info to user about packages that used, but can be substituted without damage to package

@chris48s
Copy link
Member

Just to clarify the request here, at the moment the "GitHub package.json dependency version" badge can optionally accept a :kind param telling it to look at dev or peer dependencies. This could be expanded to also cover optional .

':user/:repo/:kind(dev|peer)?/:scope(@[^/]+)?/:packageName/:branch*',

@chris48s chris48s added the good first issue New contributors, join in! label Jan 10, 2021
@paulmelnikow paulmelnikow changed the title GitHub NPM package.json - optionalDependencies Badge Request: GitHub NPM package.json - optionalDependencies Jul 9, 2021
@paulmelnikow paulmelnikow changed the title Badge Request: GitHub NPM package.json - optionalDependencies Badge request: GitHub NPM package.json - optionalDependencies Jul 9, 2021
@naz3eh
Copy link

naz3eh commented Jul 28, 2021

If this issue is unresolved, I would like to work on this issue.

@chris48s
Copy link
Member

@Nazeeh21 - go for it 👍

@calebcartwright
Copy link
Member

I thought this was sorted by #6749 (pending merge)?

@chris48s
Copy link
Member

Oh yes so it is - scratch that!

calebcartwright pushed a commit that referenced this issue Aug 3, 2021
Closes #6044

Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New contributors, join in! service-badge New or updated service badge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants