Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optionalDependencies in [GithubPackageJson]; also test [npm] #6749

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Support optionalDependencies in [GithubPackageJson]; also test [npm] #6749

merged 2 commits into from
Aug 3, 2021

Conversation

paulmelnikow
Copy link
Member

Closes #6044

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Jul 9, 2021
@paulmelnikow paulmelnikow changed the title Support optionalDependencies in [GithubPackageJson] Support optionalDependencies in [GithubPackageJson]; also test [npm] Jul 9, 2021
@shields-ci
Copy link

shields-ci commented Jul 9, 2021 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against e64313d

calebcartwright
calebcartwright approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would it be worth adding an example listing? (since we have examples for the other kinds)

@paulmelnikow
Copy link
Member Author

Yea, it could be. The existing examples are representative but I don’t think comprehensive.

It would be great if the example system were more closely aligned to the way routes are designed so we could unambiguously communicate the interface a route provides rather than generating representative examples.

@calebcartwright calebcartwright mentioned this pull request Jul 29, 2021
Closed
@calebcartwright
Copy link
Member

Yea, it could be. The existing examples are representative but I don’t think comprehensive.

It would be great if the example system were more closely aligned to the way routes are designed so we could unambiguously communicate the interface a route provides rather than generating representative examples.

Oh I hope this PR wasn't held up waiting for me to respond to this 😄

Agreed on all counts though. I believe the npm dependency version does have a comprehensive set of examples but definitely not needed here

@calebcartwright calebcartwright merged commit 37e8364 into master Aug 3, 2021
@calebcartwright calebcartwright deleted the package-json-optional branch August 3, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge request: GitHub NPM package.json - optionalDependencies
4 participants
@paulmelnikow @shields-ci @calebcartwright @shields-cd