Add codesponsor.io badge #1043
Add codesponsor.io badge #1043
Conversation
service-tests/codesponsor.js
Outdated
| .intercept(nock => nock('https://app.codesponsor.io') | ||
| .get('/shield/hopsoft/bg') | ||
| .reply(200, { | ||
| bitcoin: 0.004359, |
There was a problem hiding this comment.
This test is going to start failing if this value ever changes... Better to doJoi.number() here.
There was a problem hiding this comment.
I will fix it. Thanks you
There was a problem hiding this comment.
@Daniel15 This is now fixed. Thanks!
There was a problem hiding this comment.
Hi! Thanks for this.
There isn't consensus about how to handle showing vendor logos, particularly by default. The design goal of shields was to display clean, consistent badges. The social badges have logos, though there are only a couple other badges with logos.
Would you mind removing it until a consensus is reached? It would expedite getting this merged.
|
Update: It's fine to leave the logo checked in. With #1092 it can be turned on using |
paulmelnikow
added
service-badge
|
Are these requests expected to work without a valid token? I can't get them to. I've fiddled with the tests for a while. Feel free to ping this issue or repoen. I can't test or merge this without your help. |
|
Hi @paulmelnikow I just saw this. I apologize for the delayed reply. I will make the requested changes and will provide a token to test with. |
|
Sounds good, and no worries! |
PR for #1042