Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [Nuget MyGet] color tests #10654

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Nov 2, 2024

Noticed the following test failures:

MyGet [mocked] version (yellow badge)
[ GET /myget/mongodb/v/MongoDB.Driver.Core.json ]

AssertionError: color mismatch: expected 'orange' to equal 'yellow'
    at IcedFrisbyNock._expectField (file:///home/runner/work/shields/shields/core/service-test-runner/icedfrisby-shields.js:85:51)
    at IcedFrisbyNock.<anonymous> (file:///home/runner/work/shields/shields/core/service-test-runner/icedfrisby-shields.js:73:26)
    at IcedFrisbyNock.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:954:10)
    at Immediate.invokeNextHook (node_modules/icedfrisby/lib/icedfrisby.js:1003:24)
    at process.processImmediate (node:internal/timers:483:21)
MyGet [mocked] version (pre) (yellow badge)
[ GET /myget/mongodb/vpre/MongoDB.Driver.Core.json ]

AssertionError: color mismatch: expected 'orange' to equal 'yellow'
    at IcedFrisbyNock._expectField (file:///home/runner/work/shields/shields/core/service-test-runner/icedfrisby-shields.js:85:51)
    at IcedFrisbyNock.<anonymous> (file:///home/runner/work/shields/shields/core/service-test-runner/icedfrisby-shields.js:73:26)
    at IcedFrisbyNock.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:954:10)
    at Immediate.invokeNextHook (node_modules/icedfrisby/lib/icedfrisby.js:1003:24)
    at process.processImmediate (node:internal/timers:483:21)

These were missed out in #10630.

Ultimately, there's no longer any dedicated colour handling for NuGet and MyGet badges, we're just leveraging our standard renderVersionBadge helper logic, which is already tested elsewhere. I suggest we remove these tests.

@PyvesB PyvesB added the keep-service-tests-green Related to fixing failing tests of the services label Nov 2, 2024
@PyvesB PyvesB requested a review from jNullj November 2, 2024 15:02
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against f50c85c

@jNullj
Copy link
Member

jNullj commented Nov 2, 2024

LGTM but i'm worried about how i did not see this in ci tests at #10630.

https://github.com/badges/shields/actions/runs/11503073929

@PyvesB
Copy link
Member Author

PyvesB commented Nov 2, 2024

LGTM but i'm worried about how i did not see this in ci tests at #10630.

It's one of our slightly weird patterns. MyGet badges rely on NuGet code, it's easy to forget the former if you're changing the code of the latter. ;)

@PyvesB PyvesB added this pull request to the merge queue Nov 2, 2024
Merged via the queue into badges:master with commit 57520a9 Nov 2, 2024
24 checks passed
@PyvesB PyvesB deleted the nuget-remove-color-tests branch November 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-service-tests-green Related to fixing failing tests of the services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants