Badge For Visual Studio Marketplace added. #1074
Conversation
|
Build was falling due to #979 . |
server.js
Outdated
| { filterType: 7, value: repo }, | ||
| { filterType: 12, value: '4096' }] | ||
| }], | ||
| flags: 914 |
There was a problem hiding this comment.
What are these values? Could you add a comment?
Are the options identical between these three badges? If so could you make a createVscodeOptions to DRY this up?
There was a problem hiding this comment.
Yep identical! this is for API request. Okay I will separate it. 😃
service-tests/vscode.js
Outdated
| .get('/rating/ritwickdey.LiveServer.json') | ||
| .expectJSONTypes(Joi.object().keys({ | ||
| name: Joi.equal('rating', 'Rating'), | ||
| value: Joi.string() |
There was a problem hiding this comment.
This is very broad, and matches e.g. the string 'undefined'. What are the expected values here?
There was a problem hiding this comment.
Ok! I'll add validation
|
Hi, @paulmelnikow I've separated the identical code and fixed a test case. Please review the changes. |
ritwickdey
force-pushed
the
master
branch
2 times, most recently
from
7e3ecbe to
4d48a8f
Compare
service-tests/vscode.js
Outdated
| })); | ||
|
|
||
| t.create('version') | ||
| t.create('version should be formatted. eg. v7.2.5') |
service-tests/vscode.js
Outdated
| module.exports = t; | ||
|
|
||
| t.create('installs should be formatted. eg. 72M') | ||
| .get('/installs/ritwickdey.LiveServer.json') |
There was a problem hiding this comment.
Could you change installs to d, version to v, and rating to r for consistency? Sorry I missed this before!
There was a problem hiding this comment.
Okay. no problem.. I'll 😄
| return 0; //In case required statistic is not found means ZERO. | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for refactoring this!
|
Thinking this through a little more, would |
|
Yep, conventionally [I am totally newbie, I'll do what you suggest me] 😄 |
|
I don't think it's too long. 😄 |
|
😄 Okay. No Problem (Thanks for the suggestion).. I am now out of home. As soon as I reach to my home, I'll change all the url path. 😄 |
|
Hi @paulmelnikow, I have a question. If I want to add download badge in 3 different format (eg 7K, 7.45K or 7458). What should be routing? Should I add 3 different format? |
|
I'd prefer to use our standard number formatting using |
|
yep! I used the |
server.js
Outdated
| break; | ||
| } | ||
| case 'v': { | ||
| badgeData.text[0] = getLabel('Visual Studio Marketplace', data); |
There was a problem hiding this comment.
Could you make this lower case, like we do for the other app stores? Sorry I didn't notice it before.
There was a problem hiding this comment.
You mean that the label 'Visual Studio Marketplace' to 'visual studio marketplace'. Right?
|
Changed to lower case 😊 |
|
Thanks a bunch! |
|
Thanks a lot to you. 😃 |
Badge for Version
Badge for Total No of Installs
Badge for Rating
Issue Request #1067