Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rate limiting for test harness's use of Github #1105

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Fix rate limiting for test harness's use of Github #1105

merged 1 commit into from
Sep 28, 2017

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Sep 28, 2017 •
edited
Loading

#1095 fixed the server's use of Github, but the test harness uses it too.

Have tested locally to make sure this still works when GITHUB_TOKEN is unset.

Fix #979

@paulmelnikow
Fix Github rate limiting in CI, again
a0a17b0 
The test harness calls out to Github too.
@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Sep 28, 2017
@paulmelnikow paulmelnikow changed the title Fix Github rate limiting in CI, again Fix rate limiting for test harness's use of CI Sep 28, 2017
@paulmelnikow paulmelnikow changed the title Fix rate limiting for test harness's use of CI Fix rate limiting for test harness's use of Github Sep 28, 2017
@paulmelnikow paulmelnikow mentioned this pull request Sep 28, 2017
Closed
Daniel15
Daniel15 approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@Daniel15 Daniel15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@paulmelnikow paulmelnikow merged commit 450d861 into badges:master Sep 28, 2017
@paulmelnikow
Copy link
Member Author

Thanks Daniel!

@paulmelnikow paulmelnikow deleted the github-auth-ci-2 branch September 28, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel15 Daniel15 Daniel15 approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github rate limits cause transient service test failures in CI
2 participants
@paulmelnikow @Daniel15