Add tests for BaseService + fix hex colors #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
After this lands I'll open a PR to handle query parameters in BaseService. It'll conflict if I do it now. |
paulmelnikow
changed the title
paulmelnikow
changed the title
chris48s
approved these changes
Mar 20, 2018
| return await this.handle(namedParams); | ||
| } catch (error) { | ||
| console.log(error); | ||
| return { message: 'error' }; |
There was a problem hiding this comment.
Lets not scope creep this PR. I think this is fine for refactoring + adding tests but an improvement we should make here soon is the ability to customise this error based on the exception.
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
invokeHandlerinto its own function makes it easy to test the error handling, and also to expand the error handling as I've done in this WIP branch: master...paulmelnikow:rewrite-npm-typedefs