Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only compute user/repo if suggesting badges for GitHub #1601

Merged
merged 1 commit into from
Mar 25, 2018

Conversation

espadrine
Copy link
Member

This resolves the following error occurring in production:

TypeError: Cannot read property 'slice' of null
/home/m/shields/lib/suggest.js in findSuggestions at line 40:33
  const userRepo = url.pathname.slice(1).split('/');

This resolves the following error occurring in production:

```
TypeError: Cannot read property 'slice' of null
/home/m/shields/lib/suggest.js in findSuggestions at line 40:33
  const userRepo = url.pathname.slice(1).split('/');
```
@espadrine espadrine added the bug Bugs in badges and the frontend label Mar 25, 2018
@shields-ci
Copy link

Warnings
⚠️

This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

Messages
📖

✨ Thanks for your contribution to Shields, @espadrine!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow merged commit 0a24899 into badges:master Mar 25, 2018
@platan
Copy link
Member

platan commented Mar 27, 2018

@paulmelnikow @espadrine is this reported by Sentry? What do you think about labeling all bugs/problems reported by Sentry? This would show us how helpful Sentry is in our case.

@paulmelnikow
Copy link
Member

Yes! That sounds great.

There are a handful of open issues in Sentry and while they don’t take very long to fix, I was thinking if I open an issue for each one, I can paste in stack traces or screenshots, and we can spread the work around.

Would also be good to include tests with the future fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend sentry Bugs found using Sentry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants