[SourceForge] Fixes, tests and cleaning up #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
reviewed
Apr 2, 2018
server.js
Outdated
| let time_period, start_date; | ||
| badgeData.text[0] = getLabel('downloads', data); | ||
| // get yesterday since today is incomplete | ||
| const end_date = new Date((new Date()).getTime() - 1000*60*60*24); |
There was a problem hiding this comment.
We have moment installed. Do you know if it might provide more readable ways to express these values?
There was a problem hiding this comment.
Done, it does make things more readable! I asserted by adding a temporary log line that the number of downloads returned in the different tests were strictly equal before and after this change.
| @@ -5500,37 +5500,35 @@ cache(function(data, match, sendBadge, request) { | |||
| })); | |||
|
|
|||
| // SourceForge integration. | |||
| camp.route(/^\/sourceforge\/([^/]+)\/([^/]*)\/?(.*).(svg|png|gif|jpg|json)$/, | |||
| camp.route(/^\/sourceforge\/(dt|dm|dw|dd)\/([^/]*)\/?(.*).(svg|png|gif|jpg|json)$/, | |||
paulmelnikow
added
service-badge
paulmelnikow
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request goes through the following tasks:
/totalin the badge display for total downloads. In addition to being slightly odd, it was inconsistent with what other badges do for total downloads.Looking forward to feedback! 👍