Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ansible] Handle no data responses #1629

Merged
merged 1 commit into from
Apr 2, 2018
Merged

[Ansible] Handle no data responses #1629

merged 1 commit into from
Apr 2, 2018

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Mar 31, 2018 •
edited
Loading

This pull request addresses #1624. I managed to write a test that produced a similar error to the one we were seeing in production and consequently strengthened the existing if condition. Also switched the vars to consts while I was at it.

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS

chris48s
chris48s approved these changes Mar 31, 2018
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulmelnikow paulmelnikow added service-badge New or updated service badge sentry Bugs found using Sentry labels Apr 2, 2018
@PyvesB PyvesB merged commit 3aa2130 into badges:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
sentry Bugs found using Sentry service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PyvesB @shields-ci @paulmelnikow @chris48s