[DotnetStatus] Service deprecation #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
PyvesB
changed the title
chris48s
reviewed
Apr 1, 2018
| @@ -2940,50 +2940,12 @@ cache(function(data, match, sendBadge, request) { | |||
| }); | |||
| })); | |||
|
|
|||
| // dotnet-status integration. | |||
| // dotnet-status integration - deprecated as of April 2018. | |||
There was a problem hiding this comment.
I know we're doing this with immediate effect so we don't need to rely on isDeprecated(), but for completeness could we put an entry in https://github.com/badges/shields/blob/master/lib/deprecated-services.js . That way the info that tells us when badge code can be completely removed is all in the same place.
There was a problem hiding this comment.
I had not actually noticed that file, done. ^^
paulmelnikow
approved these changes
Apr 2, 2018
paulmelnikow
added
service-badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to discussions in #1591. It's now been over a month that the tests are failing due to the service being down (see this issue). There is no news from the author, I suggest we deprecate the service.